Register parent types before children types #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Thank you so much for the contribution, and sorry for the delay in reviewing.
Could you also add tests to Godot.SourceGenerators.Tests to ensure the generator registers the classes in the expected order? Ideally a test that failed before this PR to validate that this PR fixes it.
src/Godot.SourceGenerators/SpecCollectors/RegistrationSpecCollector.cs
Outdated
Show resolved
Hide resolved
raulsntos
reviewed
Oct 3, 2024
tests/Godot.SourceGenerators.Tests/TestData/Sources/NodesWithInheritance.cs
Outdated
Show resolved
Hide resolved
raulsntos
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Thanks, looks good to me 👍
Also, since you are a new contributor, make sure to read CONTRIBUTING.md and the contributing documentation if you haven't already.
You'll need to squash the commits before this PR can be merged. The contributing documentation contains information about squashing in case you need it.
Feel free to reach out in the development chat if you need help.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24