Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow UTF-8 names for registered members #18

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Allow UTF-8 names for registered members #18

merged 1 commit into from
Sep 2, 2024

Conversation

scgm0
Copy link
Contributor

@scgm0 scgm0 commented Sep 2, 2024

Fix #17

@scgm0 scgm0 force-pushed the Allow-utf8 branch 2 times, most recently from 7fc1a3c to ccca449 Compare September 2, 2024 06:38
raulsntos
raulsntos reviewed Sep 2, 2024
View reviewed changes
Copy link
Owner

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. Since this PR also covers signals and methods, could you change the commit message to reflect that? For example, something like Allow UTF-8 names for registered members.

src/Godot.SourceGenerators/BindMethodsWriter.cs Outdated Show resolved Hide resolved
src/Godot.SourceGenerators/BindMethodsWriter.cs Outdated Show resolved Hide resolved
src/Godot.SourceGenerators/BindMethodsWriter.cs Outdated Show resolved Hide resolved
@scgm0
Copy link
Contributor Author

scgm0 commented Sep 2, 2024

Thanks! Looks good. Since this PR also covers signals and methods, could you change the commit message to reflect that? For example, something like Allow UTF-8 names for registered members.

Thank you for the new name, I forgot to use the common c# code format, please wait.

@scgm0 scgm0 changed the title [BindProperty] Allow utf8 Allow UTF-8 names for registered members Sep 2, 2024
@scgm0
Copy link
Contributor Author

scgm0 commented Sep 2, 2024

Thanks! Looks good. Since this PR also covers signals and methods, could you change the commit message to reflect that? For example, something like Allow UTF-8 names for registered members.

Done.

@raulsntos raulsntos merged commit 9cb7bec into raulsntos:master Sep 2, 2024
3 checks passed
@raulsntos
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SourceGenerators Property naming does not support utf8
2 participants
@scgm0 @raulsntos