Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to configure a custom language server #29

Merged

Conversation

kkostov
Copy link
Contributor

@kkostov kkostov commented Jun 4, 2023

This PR enables the extension to use a custom language server.

  • Added configuration option “Language Server” expecting the path to the language_server.sh of a local build of https://github.com/elixir-lsp/elixir-ls.
  • The extension will not attempt to change permissions when using a custom language server.

Copy link
Owner

@raulchedrese raulchedrese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

Apologies for the delay in taking a look. I left a couple comments once you get a chance to take a look at those I think we can merge this.

src/novaUtils.ts Outdated Show resolved Hide resolved
src/ElixirLanguageServer.ts Outdated Show resolved Hide resolved
@kkostov
Copy link
Contributor Author

kkostov commented Jul 11, 2023

@raulchedrese, good catch! It does indeed look much better after the fix.

@raulchedrese raulchedrese merged commit 032649d into raulchedrese:master Jul 13, 2023
@kkostov kkostov deleted the allow-custom-language-server branch July 13, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants