Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dependency metrics #774

Merged

Conversation

akashsinghal
Copy link
Collaborator

@akashsinghal akashsinghal commented Apr 13, 2023

Description

What this PR does / why we need it:

Adds more metrics and accompanying dashboard additions:

  1. Registry Requests: Count, duration, status code
  2. Blob Cache Hit: Count, Hit percentage
  3. AAD exchange: duration
  4. ACR exchange: duration
  5. AKV cert fetch: duration

Adds Grafana charts for additional metrics

image
image

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #773

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Local tests pass
  • Dashboard are correct for test loads

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 74.73% and project coverage change: +0.55 🎉

Comparison is base (c3af806) 51.72% compared to head (97c2b7d) 52.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
+ Coverage   51.72%   52.28%   +0.55%     
==========================================
  Files          61       61              
  Lines        3555     3653      +98     
==========================================
+ Hits         1839     1910      +71     
- Misses       1529     1551      +22     
- Partials      187      192       +5     
Impacted Files Coverage Δ
pkg/certificateprovider/azurekeyvault/provider.go 42.67% <0.00%> (-1.12%) ⬇️
...n/oras/authprovider/azure/azureworkloadidentity.go 34.24% <0.00%> (-1.47%) ⬇️
pkg/metrics/stats_reporter.go 79.31% <75.00%> (-3.85%) ⬇️
pkg/referrerstore/oras/oras.go 55.26% <100.00%> (+1.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akashsinghal akashsinghal self-assigned this Apr 14, 2023
@akashsinghal akashsinghal marked this pull request as ready for review April 14, 2023 20:06
pkg/certificateprovider/azurekeyvault/provider.go Outdated Show resolved Hide resolved
pkg/metrics/stats_reporter.go Show resolved Hide resolved
pkg/metrics/stats_reporter.go Show resolved Hide resolved
pkg/referrerstore/oras/oras.go Show resolved Hide resolved
pkg/referrerstore/oras/oras.go Outdated Show resolved Hide resolved
@akashsinghal akashsinghal requested a review from binbin-li April 18, 2023 17:46
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor comment, lgtm overall

@akashsinghal akashsinghal merged commit c64a565 into ratify-project:main Apr 20, 2023
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dependency metrics
2 participants