Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add commits doc to contributing guide #1844

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

susanshi
Copy link
Collaborator

@susanshi susanshi commented Oct 2, 2024

Description

What this PR does / why we need it:

PR contains the below changes to the contributing guide

1.added table of content
2.added a section for Commits ( verbiage from notary project)
3.add a youtube link for vscode debug recording

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

CONTRIBUTING.md Outdated Show resolved Hide resolved
@akashsinghal akashsinghal enabled auto-merge (squash) October 7, 2024 05:59
@akashsinghal akashsinghal merged commit 5327afe into ratify-project:dev Oct 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants