Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default templates #1776

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

junczhu
Copy link
Collaborator

@junczhu junczhu commented Sep 3, 2024

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

As discussed in community meeting, please validate scenario :

  1. install Ratify 1.2
  2. upgrade to Latest ratify with updated verifier
  • manual test
    No change in default template and there would be no breaking change.
    Verified that if we need replace and using the apply command to apply the new config can cause a problem:
    image

AKS tests passed in my fork:
image

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 19 files with indirect coverage changes

@junczhu junczhu marked this pull request as ready for review September 3, 2024 07:23
@binbin-li binbin-li enabled auto-merge (squash) September 5, 2024 03:21
@binbin-li binbin-li merged commit 6487002 into ratify-project:dev Sep 5, 2024
19 checks passed
akashsinghal pushed a commit to akashsinghal/ratify that referenced this pull request Sep 13, 2024
binbin-li pushed a commit to binbin-li/ratify that referenced this pull request Sep 14, 2024
@junczhu junczhu deleted the tsa-template-crds branch January 13, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants