-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add refreshInterval to the helm chart Values #1773
Merged
binbin-li
merged 4 commits into
ratify-project:dev
from
shahramk64:skalantari/Configure-kmp-refresh-interval-in-Ratify-default-helm-chart
Sep 3, 2024
Merged
feat: Add refreshInterval to the helm chart Values #1773
binbin-li
merged 4 commits into
ratify-project:dev
from
shahramk64:skalantari/Configure-kmp-refresh-interval-in-Ratify-default-helm-chart
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
shahramk64
force-pushed
the
skalantari/Configure-kmp-refresh-interval-in-Ratify-default-helm-chart
branch
2 times, most recently
from
September 3, 2024 01:43
de73f00
to
a2ffe16
Compare
shahramk64
force-pushed
the
skalantari/Configure-kmp-refresh-interval-in-Ratify-default-helm-chart
branch
from
September 3, 2024 01:44
a2ffe16
to
5d08645
Compare
shahramk64
changed the title
Add refreshInterval to the helm chart Values
feat: Add refreshInterval to the helm chart Values
Sep 3, 2024
shahramk64
requested review from
akashsinghal,
binbin-li,
jimmyraywv,
luisdlp,
susanshi and
toddysm
as code owners
September 3, 2024 01:46
binbin-li
reviewed
Sep 3, 2024
binbin-li
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for adding it!
…Ratify-default-helm-chart
akashsinghal
pushed a commit
to akashsinghal/ratify
that referenced
this pull request
Sep 13, 2024
Signed-off-by: akashsinghal <[email protected]>
binbin-li
pushed a commit
to binbin-li/ratify
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
This PR adds refreshInterval to Values.yaml so that the installation of ratify can support dynamic certificate refresh.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1755
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Two scenarios were tested:
Scenario 1:
returns version: d53015bda2dc4f24923143e8535c4ed2%
Make sure a new certificate is created in your Azure key vault by checking your Azure portal.
kubectl get keymanagementprovider kmp-akv-refresh-nill -o jsonpath='{.status.properties.Certificates[0].Version}'
returns: d53015bda2dc4f24923143e8535c4ed2%
As expected, It should return the old certificate version, because the refreshInterval was left blank in the config file.
To make sure it was nil, run
kubectl describe keymanagementprovider kmp-akv-refresh-nill
shows “Refresh Interval: “
Scenario 2
shows “Refresh Interval: 20s“
run
kubectl get keymanagementprovider kmp-akv-refresh -o jsonpath='{.status.properties.Certificates[0].Version}'
returns version: 2f42ed3d160145aca51d78c59ba9cd57%
create a new certificate in your azure key vault after a few seconds, then run
az keyvault certificate create --vault-name skal21kv --name wabbit-networks-io --policy @new-policy.json
Make sure a new certificate is created in your Azure key vault by checking your Azure portal.
wait at least 20 seconds, then run
kubectl get keymanagementprovider kmp-akv-refresh -o jsonpath='{.status.properties.Certificates[0].Version}'
As expected, it fetches the new version and returns: 01a3761c92e24adb85ca9036c4e6b2bf%
Checklist:
Post Merge Requirements
Helm Chart Change