-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance CR status with clearer brief error message #1734
Conversation
735db82
to
ac56ec3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Binbin. Left some questions on the clustered controllers , some are also applicable to namespaced controllers. let me know if you have any questions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks Binbin!
…ect#1734) Signed-off-by: akashsinghal <[email protected]>
Description
What this PR does / why we need it:
The PR will address the issue that brief error is too short. Basically, the brief error will just contain the error code and root cause. And if it exceeds the max length(150 charactoers), the brief error will be truncated.
GetConciseError
method to custom error to create an error message consisting of the error code and reason.GetConciseError
method to assign brief error value.Examples:
Screenshot for Policy CR:
Screenshot for Verifier CR:
Screenshot for KMP CR:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1453
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change