-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update the contributing guide for a successful cli debugging #1718
Merged
akashsinghal
merged 4 commits into
ratify-project:dev
from
shahramk64:skalantari/update-debugging-guidelines-for-CLI
Aug 21, 2024
Merged
docs: update the contributing guide for a successful cli debugging #1718
akashsinghal
merged 4 commits into
ratify-project:dev
from
shahramk64:skalantari/update-debugging-guidelines-for-CLI
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
binbin-li
reviewed
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
binbin-li
previously approved these changes
Aug 19, 2024
susanshi
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
Please start with |
binbin-li
approved these changes
Aug 21, 2024
akashsinghal
approved these changes
Aug 21, 2024
duffney
pushed a commit
to duffney/ratify
that referenced
this pull request
Aug 23, 2024
akashsinghal
pushed a commit
to akashsinghal/ratify
that referenced
this pull request
Sep 13, 2024
…atify-project#1718) Signed-off-by: akashsinghal <[email protected]>
binbin-li
pushed a commit
to binbin-li/ratify
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
Following the guidelines in the Contributing file to debug the cli scenario does not result in a successful run. It seems that it assumes that a default config file exists in a specific path, which is not correct. A config file should be created for the cli scenario and it should be provided as an argument in the sample launch.json.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1717
Type of change
main
branch)How Has This Been Tested?
It was tested by updating launch.json with the proposed sample json blob, and downloading
notation.crt
and makingconfig_cli.json
point to the downloaded file as described in the updated guide. After that, debugging with vscode results in a successful verification report.Checklist:
Post Merge Requirements
Helm Chart Change