-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add image signing for dev images and add release sbom #1629
build: add image signing for dev images and add release sbom #1629
Conversation
View sample success run here: https://github.com/akashsinghal/ratify/actions/runs/9898814007/job/27346427829 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d483836
to
4f45a60
Compare
4f45a60
to
7291210
Compare
725d6f5
to merge after #1641 |
After this PR is merged, the following secrets and variables MUST be added to Ratify and each fork of Ratify that will run AKS and dev publishing workflows: Secrets:
Variables:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
…project#1629) Signed-off-by: akashsinghal <[email protected]>
Description
What this PR does / why we need it:
.well-known/ratify-verification.crt
. Note the cert will be downloaded from the ratify.dev website. See docs: add signature verification guidance for dev assets ratify-web#95Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1658
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change