Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linting issues #1606

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

akashsinghal
Copy link
Collaborator

@akashsinghal akashsinghal commented Jul 2, 2024

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1607

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

dependabot bot and others added 5 commits July 2, 2024 01:46
Bumps [github.com/sigstore/sigstore](https://github.com/sigstore/sigstore) from 1.8.4 to 1.8.6.
- [Release notes](https://github.com/sigstore/sigstore/releases)
- [Commits](sigstore/sigstore@v1.8.4...v1.8.6)

---
updated-dependencies:
- dependency-name: github.com/sigstore/sigstore
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Files Coverage Δ
cmd/ratify/cmd/verify.go 66.07% <100.00%> (ø)
httpserver/handlers.go 75.53% <100.00%> (ø)
httpserver/tlsManager.go 66.66% <100.00%> (ø)
pkg/referrerstore/oras/oras.go 67.78% <100.00%> (ø)
pkg/verifier/notation/pluginmanager.go 71.42% <100.00%> (ø)
cmd/ratify/cmd/discover.go 18.51% <0.00%> (ø)
cmd/ratify/cmd/resolve.go 35.13% <0.00%> (ø)
cmd/ratify/cmd/root.go 72.72% <50.00%> (ø)
cmd/ratify/cmd/serve.go 43.39% <0.00%> (ø)
cmd/ratify/cmd/version.go 31.03% <0.00%> (ø)
... and 2 more

... and 24 files with indirect coverage changes

pkg/referrerstore/oras/oras.go Dismissed Show dismissed Hide dismissed
@akashsinghal akashsinghal marked this pull request as ready for review July 3, 2024 00:02
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix!

@akashsinghal akashsinghal enabled auto-merge (squash) July 3, 2024 18:01
@akashsinghal akashsinghal merged commit 89b0a9c into ratify-project:dev Jul 3, 2024
17 of 18 checks passed
duffney pushed a commit to duffney/ratify that referenced this pull request Jul 10, 2024
akashsinghal added a commit to akashsinghal/ratify that referenced this pull request Sep 13, 2024
binbin-li pushed a commit to binbin-li/ratify that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all golang ci linting errors
2 participants