-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update ratify charts to 1.2 #1526
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1526 +/- ##
=======================================
Coverage 68.15% 68.15%
=======================================
Files 119 119
Lines 6139 6139
=======================================
Hits 4184 4184
Misses 1561 1561
Partials 394 394 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -115,7 +144,7 @@ releases: | |||
value: true | |||
- name: logger.level | |||
value: debug | |||
- name: notationCert | |||
- name: notationCerts[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @akashsinghal , I want to double check here did we remove support for notationCert in 1.2 charts? do you think we need to update the releaseNotes to include this as a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notationCert is not removed but is marked as deprecated. I will add a note on deprecation in release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline that we need to consider adding tests to make sure these deprecated values still are supported
Signed-off-by: akashsinghal <[email protected]>
Description
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Covered by e2e
Checklist:
Post Merge Requirements
Helm Chart Change