Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge dev into main 5-23-24 #1499

Merged
merged 12 commits into from
May 24, 2024
Merged

chore: merge dev into main 5-23-24 #1499

merged 12 commits into from
May 24, 2024

Conversation

akashsinghal
Copy link
Collaborator

Description

What this PR does / why we need it:

  • merges dev into main

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

dependabot bot and others added 9 commits May 20, 2024 10:54
@dependabot
chore: Bump actions/checkout from 4.1.5 to 4.1.6 (#1485)
daba3f0 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: Bump k8s.io/api from 0.28.9 to 0.28.10 (#1493)
9aea86d 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: Bump github.com/aws/aws-sdk-go-v2/config from 1.27.13 to 1.27.…
4800d40 
…15 (#1492)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: Bump k8s.io/client-go from 0.28.9 to 0.28.10 (#1491)
e0889f8 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: Bump github/codeql-action from 2.13.4 to 3.25.5 (#1487)
acfdf81 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: Bump golang from 392d2b6 to 16438a8 in /httpserver (#1488)
e062893 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@akashsinghal
chore: ignore CVE-2023-42366 (#1494)
09ce389
@dependabot
chore: Bump github/codeql-action from 3.25.5 to 3.25.6 (#1495)
d048744 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: Bump codecov/codecov-action from 4.4.0 to 4.4.1 (#1496)
0a9640b
susanshi
susanshi previously approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the reminder! lets merge this one in the community meeting.

@susanshi
Copy link
Collaborator

thanks for the reminder! lets merge this one in the community meeting.

looks like all the AKS test is having some issues

susanshi
susanshi reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@susanshi susanshi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending AKS failure investigation, "gpg: cannot open '/dev/tty': No such device or address"

@susanshi susanshi self-requested a review May 21, 2024 23:58
@akashsinghal
Copy link
Collaborator Author

@susanshi @binbin-li I think we're ready to merge this? The AKS test is unblocked thanks to Binbin's efforts.

@akashsinghal akashsinghal changed the title chore: merge dev into main 5-22-24 chore: merge dev into main 5-23-24 May 23, 2024
junczhu
junczhu approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@junczhu junczhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akashsinghal akashsinghal merged commit c92687d into main May 24, 2024
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junczhu junczhu junczhu approved these changes

@susanshi susanshi susanshi approved these changes

@binbin-li binbin-li Awaiting requested review from binbin-li binbin-li is a code owner

@jimmyraywv jimmyraywv Awaiting requested review from jimmyraywv jimmyraywv is a code owner

@luisdlp luisdlp Awaiting requested review from luisdlp luisdlp is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akashsinghal @susanshi @junczhu @binbin-li