-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add unit tests for KMP and CertStore controllers #1439
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1439 +/- ##
==========================================
+ Coverage 66.76% 68.16% +1.39%
==========================================
Files 116 119 +3
Lines 6030 6134 +104
==========================================
+ Hits 4026 4181 +155
+ Misses 1620 1559 -61
- Partials 384 394 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests!
The merge-base changed after approval.
32783fe
to
c14bb65
Compare
c14bb65
to
3d08b0a
Compare
3d08b0a
to
63fe951
Compare
eac4fea
to
681ce70
Compare
pkg/controllers/clusterresource/keymanagementprovider_controller_test.go
Outdated
Show resolved
Hide resolved
0eb977c
to
a27406d
Compare
…t#1439) Signed-off-by: akashsinghal <[email protected]>
Description
What this PR does / why we need it:
Added some unit tests for KMP and CertStore to cover the basic reconcile logics. Check diff at: binbin-li#148
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change