-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add NamespacedVerifier CRD [multi-tenancy PR 11] #1428
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1428 +/- ##
==========================================
- Coverage 66.76% 66.73% -0.03%
==========================================
Files 116 119 +3
Lines 6030 6133 +103
==========================================
+ Hits 4026 4093 +67
- Misses 1620 1659 +39
+ Partials 384 381 -3 ☔ View full report in Codecov by Sentry. |
b52f711
to
641a76a
Compare
641a76a
to
f977961
Compare
config/samples/namespaced/verifier/config_v1beta1_verifier_notation_kmprovider.yaml
Show resolved
Hide resolved
f977961
to
80c51d1
Compare
ce2415f
to
758e479
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
The merge-base changed after approval.
@akashsinghal thanks for your review! Just merged dev to resolve the conflicts, could you have another quick review? There should be no diff in this patch. |
…t#1428) Co-authored-by: Akash Singhal <[email protected]> Signed-off-by: akashsinghal <[email protected]>
…t#1428) Co-authored-by: Akash Singhal <[email protected]>
Description
What this PR does / why we need it:
This is the 11th PR for multi-tenancy support. Please review #1423 first. Check diff between PR 10 and PR 11 at: binbin-li#144
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change