Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NamespacedVerifier CRD [multi-tenancy PR 11] #1428

Merged
merged 28 commits into from
May 4, 2024

Conversation

binbin-li
Copy link
Collaborator

@binbin-li binbin-li commented Apr 30, 2024

Description

What this PR does / why we need it:

This is the 11th PR for multi-tenancy support. Please review #1423 first. Check diff between PR 10 and PR 11 at: binbin-li#144

  1. Created new CRD: NamespacedVerifier for namespaced verifier resource and corresponding controller.
  2. Updated implementaion of ActiveVerifiers so that it supports managing verifiers across namespaces.
  3. Updated controllers to reduce duplicate code between namespaced and clustered controllers.
  4. Moved all sample CRs under clustered/namespaced folders.
  5. Added unit tests.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@binbin-li binbin-li marked this pull request as draft April 30, 2024 08:52
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 81.91489% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 66.73%. Comparing base (1bd347c) to head (653bded).
Report is 5 commits behind head on dev.

Files Patch % Lines
...ntrollers/namespaceresource/verifier_controller.go 80.00% 7 Missing and 1 partial ⚠️
pkg/manager/manager.go 0.00% 8 Missing ⚠️
...controllers/clusterresource/verifier_controller.go 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1428      +/-   ##
==========================================
- Coverage   66.76%   66.73%   -0.03%     
==========================================
  Files         116      119       +3     
  Lines        6030     6133     +103     
==========================================
+ Hits         4026     4093      +67     
- Misses       1620     1659      +39     
+ Partials      384      381       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binbin-li binbin-li force-pushed the multi-tenancy-pr-11 branch from b52f711 to 641a76a Compare April 30, 2024 08:57
@binbin-li binbin-li changed the title [WIP] feat: add NamespacedVerifier CRD [multi-tenancy PR 11] feat: add NamespacedVerifier CRD [multi-tenancy PR 11] Apr 30, 2024
@binbin-li binbin-li marked this pull request as ready for review April 30, 2024 11:02
@binbin-li binbin-li force-pushed the multi-tenancy-pr-11 branch from 641a76a to f977961 Compare May 1, 2024 01:56
@binbin-li binbin-li force-pushed the multi-tenancy-pr-11 branch from f977961 to 80c51d1 Compare May 2, 2024 11:48
@binbin-li binbin-li force-pushed the multi-tenancy-pr-11 branch from ce2415f to 758e479 Compare May 3, 2024 14:37
akashsinghal
akashsinghal previously approved these changes May 3, 2024
Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@binbin-li binbin-li dismissed akashsinghal’s stale review May 4, 2024 00:12

The merge-base changed after approval.

@binbin-li
Copy link
Collaborator Author

LGTM. Thanks

@akashsinghal thanks for your review! Just merged dev to resolve the conflicts, could you have another quick review? There should be no diff in this patch.

@binbin-li binbin-li merged commit e13af40 into ratify-project:dev May 4, 2024
17 checks passed
akashsinghal added a commit to akashsinghal/ratify that referenced this pull request Sep 13, 2024
binbin-li added a commit to binbin-li/ratify that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants