Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NamespacedStore CRD [multi-tenancy PR 8] #1413

Merged
merged 14 commits into from
Apr 29, 2024

Conversation

binbin-li
Copy link
Collaborator

@binbin-li binbin-li commented Apr 23, 2024

Description

What this PR does / why we need it:

This is the 8th PR for multi-tenancy support. Please review #1402 first. Check diff between PR 7 and PR 8 at: binbin-li#130

  1. Created new CRD: NamespacedStore for namespaced Store resource and corresponding controller.
  2. Updated implementation of ActiveStore so that it supports managing stores across namespaces.
  3. Updated controlllers to reduce duplicate code between namespaced and clustered controllers.
  4. Add unit tests.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 20 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@f006b88). Click here to learn what that means.

Files Patch % Lines
.../controllers/namespaceresource/store_controller.go 66.66% 11 Missing and 2 partials ⚠️
pkg/manager/manager.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #1413   +/-   ##
======================================
  Coverage       ?   66.81%           
======================================
  Files          ?      116           
  Lines          ?     6029           
  Branches       ?        0           
======================================
  Hits           ?     4028           
  Misses         ?     1618           
  Partials       ?      383           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binbin-li binbin-li force-pushed the multi-tenancy-pr-8 branch from 0d06ef6 to 257984a Compare April 24, 2024 13:53
@binbin-li binbin-li changed the title [WIP] feat: add NamespacedStore CRD [multi-tenancy PR 8] feat: add NamespacedStore CRD [multi-tenancy PR 8] Apr 24, 2024
@binbin-li binbin-li force-pushed the multi-tenancy-pr-8 branch from 257984a to afe6476 Compare April 25, 2024 09:58
@binbin-li binbin-li force-pushed the multi-tenancy-pr-8 branch from afe6476 to 76d6c74 Compare April 25, 2024 15:06
@binbin-li binbin-li force-pushed the multi-tenancy-pr-8 branch from 76d6c74 to 7521fb2 Compare April 25, 2024 15:28
@binbin-li binbin-li force-pushed the multi-tenancy-pr-8 branch from 3d0b1a7 to db364e6 Compare April 26, 2024 12:04
Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks!

@binbin-li binbin-li merged commit 9ab83c8 into ratify-project:dev Apr 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants