-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update ReferrerNotFound error to be more accurate #1408
Conversation
89586cb
to
037f0d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this! Just a reminder that we'll need to update the docs too :)
@yizha1 do you think if the new description makes sense to customers? Any suggestions for improvement? |
037f0d1
to
d863879
Compare
synced with Yi offline, rename the error code to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1408 +/- ##
======================================
Coverage ? 65.58%
======================================
Files ? 109
Lines ? 5579
Branches ? 0
======================================
Hits ? 3659
Misses ? 1565
Partials ? 355 ☔ View full report in Codecov by Sentry. |
285bc56
to
cedb997
Compare
Description
What this PR does / why we need it:
WithDescription
to custom error for improved printout capability.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixing one error in: #1321
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change