-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PolicyManager interface to wrap operations on namespaced policies [multi-tenancy PR 3] #1359
feat: add PolicyManager interface to wrap operations on namespaced policies [multi-tenancy PR 3] #1359
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1359 +/- ##
===========================================
- Coverage 65.31% 65.26% -0.06%
===========================================
Files 105 106 +1
Lines 5458 5533 +75
===========================================
+ Hits 3565 3611 +46
- Misses 1535 1567 +32
+ Partials 358 355 -3 ☔ View full report in Codecov by Sentry. |
e55723f
to
03c3828
Compare
03c3828
to
33adbbf
Compare
33adbbf
to
c9c5705
Compare
53d89e3
to
2b6fcfb
Compare
2b6fcfb
to
d62793d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
What this PR does / why we need it:
This is the third PR for multi-tenancy support. Please review this pr first.
PolicyManager
interface to wrap operations on namespaced policy resources.PolicyManager
interface instead of directly accessing policies.ActivePolicies
undercontrollers
toresource_map.go
so that it can be shared by clustered and namespaced controllers in the future.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change