-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate plugin name on CR create #1265
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
- Coverage 61.72% 61.72% -0.01%
==========================================
Files 97 97
Lines 6190 6236 +46
==========================================
+ Hits 3821 3849 +28
- Misses 2038 2054 +16
- Partials 331 333 +2 ☔ View full report in Codecov by Sentry. |
@junczhu , @akashsinghal , @binbin-li , this PR is ready for review when you get a chance, thanks! |
Signed-off-by: Susan Shi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Description
#1089
This PR adds substatus property to Verifier and Store CR. The controllers are also updated to validate plugin path.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes # 1089
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Added unit test and e2e test for writing success and failure status in verifier and store
Checklist:
Post Merge Requirements
Helm Chart Change