Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add dev helm chart publishing workflow #1209

Merged

Conversation

akashsinghal
Copy link
Collaborator

@akashsinghal akashsinghal commented Dec 9, 2023

Description

What this PR does / why we need it:

  • Removes all dev image publishing from release publish workflow (less chance for erroneous errors)
  • Introduces dedicated dev-assets-publishing workflow to build CRD + Ratify + plugin + chart publishing
    • triggered every week Sunday morning 08:30 UTC
    • publishes dev helm chart with rolling tag 0-dev and 0-dev.<YYYYMMDD>.<7-character-commit-hash>. dev chart points to updated CRD + plugins dev image (Note 0- must be prepended for semver compatibility with helm)
    • publishes ratify CRD + ratify base + ratify plugins image. Each tagged with 0-dev.<YYYYMMDD>.<7-character-commit-hash> AND rolling tag latest
  • updates dev.helmfile.yaml & dev.highavailability.yaml to point to rolling tag chart 0-dev and removes other previous manual value overrides
  • updates dev.highavailability.yaml to install gatekeeper and constraint + constraint template. No longer any dependency on dev.helmfile.yaml.
  • updates docs on how to use dev.helmfile.yaml and new streamlined release guidance.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2c51b6) 61.43% compared to head (7389568) 61.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1209   +/-   ##
=======================================
  Coverage   61.43%   61.43%           
=======================================
  Files          97       97           
  Lines        6179     6179           
=======================================
  Hits         3796     3796           
  Misses       2051     2051           
  Partials      332      332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akashsinghal akashsinghal marked this pull request as ready for review December 27, 2023 19:08
junczhu
junczhu previously approved these changes Jan 1, 2024
Copy link
Collaborator

@junczhu junczhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

susanshi
susanshi previously approved these changes Jan 2, 2024
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@akashsinghal akashsinghal dismissed stale reviews from susanshi and junczhu via f59cc04 January 4, 2024 01:42
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks

@akashsinghal akashsinghal merged commit 5333fe9 into ratify-project:main Jan 4, 2024
21 checks passed
@akashsinghal akashsinghal mentioned this pull request Feb 2, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants