-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vulnerability report verifier to helm chart #1196
feat: add vulnerability report verifier to helm chart #1196
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
+ Coverage 54.46% 54.67% +0.21%
==========================================
Files 103 85 -18
Lines 6696 5657 -1039
==========================================
- Hits 3647 3093 -554
+ Misses 2722 2307 -415
+ Partials 327 257 -70 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
wonder if we should add a sample CR under config directory? And what about the CLI case? |
I added a couple CR samples under config directory here: https://github.com/deislabs/ratify/blob/main/config/samples/config_v1beta1_verifier_vulnerabilityreport.yaml. They are used by e2e tests. For CLI there's also one used by bats test like the other verifiers here: https://github.com/deislabs/ratify/blob/main/test/bats/tests/config/vulnerabilityreport_config.json. I can update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change