-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add license-checker #1176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
requested review from
akashsinghal,
jimmyraywv,
luisdlp,
susanshi and
toddysm
as code owners
November 16, 2023 06:58
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
=======================================
Coverage 52.56% 52.56%
=======================================
Files 101 101
Lines 6344 6344
=======================================
Hits 3335 3335
Misses 2688 2688
Partials 321 321 ☔ View full report in Codecov by Sentry. |
binbin-li
force-pushed
the
license-checker
branch
from
November 16, 2023 07:36
f90578f
to
5735ec2
Compare
binbin-li
force-pushed
the
license-checker
branch
4 times, most recently
from
November 20, 2023 06:22
c2b840e
to
f1177ab
Compare
binbin-li
force-pushed
the
license-checker
branch
3 times, most recently
from
November 20, 2023 08:47
3065225
to
fe57dab
Compare
Signed-off-by: Binbin Li <[email protected]>
binbin-li
force-pushed
the
license-checker
branch
from
November 20, 2023 08:54
fe57dab
to
dc79ea8
Compare
binbin-li
changed the title
[WIP] build: add license-checker
build: add license-checker
Nov 20, 2023
junczhu
previously approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
binbin-li
force-pushed
the
license-checker
branch
from
November 21, 2023 04:29
597a6f2
to
9fdf8a5
Compare
binbin-li
force-pushed
the
license-checker
branch
2 times, most recently
from
November 21, 2023 05:57
4ffe084
to
72f65a0
Compare
binbin-li
force-pushed
the
license-checker
branch
2 times, most recently
from
November 21, 2023 06:46
abb2046
to
a79f91a
Compare
binbin-li
force-pushed
the
license-checker
branch
from
November 21, 2023 06:59
a79f91a
to
1a54bdd
Compare
binbin-li
force-pushed
the
license-checker
branch
from
November 22, 2023 04:28
1a54bdd
to
40122ce
Compare
binbin-li
force-pushed
the
license-checker
branch
from
November 22, 2023 04:30
40122ce
to
2e93ef8
Compare
akashsinghal
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
This pr adds a CI job to check the license header and dependency licenses. It added missing headers to files. And the report shows that there are 2 dependencies are under incompatible license as below screenshot:
The CR one is due to missing LICENSE defined in the v1.0.1, which was added in v2.0.0. However, this is a indirect dependency from
github.com/sigstore/cosign/v2
, which is not controlled by Ratify.The go-metrics one is under BSD-2-Clause-Views, which is not compatible with Apache 2.0. All compatible and weak compatible licenses are listed in: https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
The go-metrics is indirect dependency from
github.com/sigstore/cosign/v2
as well.Created issue on cosign: sigstore/cosign#3377
Since those are indirect dependencies, there is no way to fix the broken check. We could have 3 options for it:
As discussed in the PR review meeting, we'll adopt option 3 to exclude those 2 libraries.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change