Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add certificates to chart value #1172

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

susanshi
Copy link
Collaborator

@susanshi susanshi commented Nov 10, 2023

Description

What this PR does / why we need it:

Update Ratify default helm chart to allow specification of akv cert Array
Quick start doc updated at https://github.com/deislabs/ratify-web/pull/33/files

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1145

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Covered by AKS e2e test. Please see test result at https://github.com/susanshi/ratify/actions/runs/6857271594

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29a38b6) 52.39% compared to head (b3b5b91) 52.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1172   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files         101      101           
  Lines        6344     6344           
=======================================
  Hits         3324     3324           
  Misses       2699     2699           
  Partials      321      321           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susanshi susanshi marked this pull request as ready for review November 14, 2023 00:29
@susanshi susanshi merged commit a47bdc6 into ratify-project:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[helm] Make default verifier more configurable
2 participants