test: update e2e CLI 2

Signed-off-by: Juncheng Zhu <[email protected]>
ratify-project · Dec 12, 2024 · c4d46c5 · c4d46c5
1 parent d3a1302
commit c4d46c5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/scripts/generate-crl-testing-certs.sh b/scripts/generate-crl-testing-certs.sh
@@ -17,7 +17,7 @@
 # - certchain_with_crl.pem: the fullchain file that includes the leaf 
 #   certificate with CRL, intermediate certificate with invalid OCSP and valid 
 #   CRL, and the root certificate.
-# - leaf.crl: the CRL file that includes the revoked leaf certificate.
+# - leaf.crl: the CRL file that includes the leaf certificate.
 # - leaf.key: the private key of the leaf certificate.
 # - leaf_revoked.crl: the CRL file that includes the revoked leaf certificate.
 # - intermediate.crl: the CRL file that includes the intermediate certificate.

diff --git a/test/bats/cli-test.bats b/test/bats/cli-test.bats
@@ -35,7 +35,7 @@ load helpers
 }
 
 @test "notation verifier crl test" {
-    python3 ./scripts/crl_server.py & CRL_SERVER_PID = $(shell $!)
+    CRL_SERVER_PID = run_crl_server
 
     run bin/ratify verify -c $RATIFY_DIR/config_notation_crl.json -s $TEST_REGISTRY/notation:crl
     assert_cmd_verify_success

diff --git a/test/bats/helpers.bash b/test/bats/helpers.bash
@@ -111,3 +111,8 @@ wait_for_process() {
   done
   return 1
 }
+
+run_crl_server() {
+  python3 ./scripts/crl_server.py & CRL_SERVER_PID=$!
+  return $CRL_SERVER_PID
+}