Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: incorrect description of the named_install step #213

Closed
Tracked by #212
perillo opened this issue Apr 4, 2023 · 1 comment
Closed
Tracked by #212

build: incorrect description of the named_install step #213

perillo opened this issue Apr 4, 2023 · 1 comment

Comments

@perillo
Copy link
Contributor

perillo commented Apr 4, 2023

Currently, the named_install step is defined as:

const named_install = b.step(b.fmt("{s}_install", .{key}), b.fmt("Install {s} to zig-cache/bin", .{ex.main_file}));

However the executable, by default, is installed in zig-out/bin, not zig-cache/bin.
Moreover, the user can change the destination, with the -p --prefix or --prefix-exe-dir options.

I will fix it.

By the way: is it really necessary to add an install step?

@chrboesch
Copy link
Collaborator

By the way: is it really necessary to add an install step?

No, if you can do without, that's fine too.

@perillo perillo mentioned this issue Apr 5, 2023
4 tasks
vamega pushed a commit to vamega/ziglings that referenced this issue Jul 25, 2023
Replace the description of the named_install step from
"Install {s} to zig-cache/bin" to "Copy {s} to prefix path".  The latter
has been adapded from the description of the builtin install step.

Ad an empty line before the build_step variable, in order to improve
readability.

Closes ratfactor#213
fleimgruber pushed a commit to fleimgruber/ziglings that referenced this issue Oct 26, 2023
Replace the description of the named_install step from
"Install {s} to zig-cache/bin" to "Copy {s} to prefix path".  The latter
has been adapded from the description of the builtin install step.

Ad an empty line before the build_step variable, in order to improve
readability.

Closes ratfactor#213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants