fix(tabs)!: set the default highlight_style #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
mindoodoo,
sayanarijit and
kdheepak
as code owners
github-actions
bot
added
the
Type: Breaking Change
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
=======================================
+ Coverage 90.5% 90.7% +0.1%
=======================================
Files 41 41
Lines 11980 11978 -2
=======================================
+ Hits 10853 10867 +14
+ Misses 1127 1111 -16 ☔ View full report in Codecov by Sentry. |
Previously the default highlight_style was set to `Style::default()`, which meant that the highlight style was the same as the normal style. This change sets the default highlight_style to reversed text. BREAKING CHANGE: The `Tab` widget now renders the highlight style as reversed text by default. This can be changed by setting the `highlight_style` field of the `Tab` widget.
joshka
force-pushed
the
tabs-highlight-default
branch
from
16e58db to
634e003
Compare
|
Added commit just fixes up conflict in breaking_changes.md |
|
Ping @kdheepak for additional review. |
kdheepak
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the default highlight_style was set to
Style::default(),which meant that the highlight style was the same as the normal style.
This change sets the default highlight_style to reversed text.
BREAKING CHANGE: The
Tabwidget now renders the highlight style asreversed text by default. This can be changed by setting the
highlight_stylefield of theTabwidget.