chore(examples): refactor some examples #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysd
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
rhysd
force-pushed
the
improve-examples
branch
2 times, most recently
from
869fc15 to
c3369b7
Compare
Codecov Report
@@ Coverage Diff @@
## main #578 +/- ##
=======================================
Coverage 89.56% 89.56%
=======================================
Files 41 41
Lines 11570 11570
=======================================
Hits 10363 10363
Misses 1207 1207 |
…ing_sub` Signed-off-by: rhysd <[email protected]>
Signed-off-by: rhysd <[email protected]>
rhysd
force-pushed
the
improve-examples
branch
from
c3369b7 to
82465f1
Compare
orhun
approved these changes
Oct 20, 2023
orhun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves some examples a bit.
Duration::checked_subandOption::unwrap_or_elsecalls can be simplified with singleDuration::saturating_subcall.poll_inputshould not be ignored intermwizsupport example.