-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(showcase): showcase tabs widget #391
Conversation
8b69e46
to
4cd76f1
Compare
Thanks for this. A couple of things:
|
c401cfb
to
4cd76f1
Compare
+1 to the dropping the border. Perhaps give a couple of examples. I like the format (TODO,... DONE) you've chosen as the first choice. Let's add a second one like new tabs example (though with just the tabs, not the body and remove the dividers / padding) ratatui/ratatui#855 This one makes some sense to animate (slowly - use 1s per tab.). For that, make sure to add a "Hide" line to the beginning of the tape (before cargo run) and then sleep 2s after the run before "Show". Also sleep 2s at the start of the tape. Don't worry about making the code have to wrap the tabs around, the tape will automatically loop back to the first item. |
@Valentin271 My bad I didn't realise Thank you both for the feedback on improving the showcase. I will work on animating and adding a second example. |
No problem at all, that's on our end, its currently poorly documented. As you can see I've just introduced a check for that. Did you |
I ran |
Yeah all good! |
* chore(Cargo.toml): change "time" to "dep:time" * docs(lib): document optional and default features
Relates to #249