Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp installs process listeners multiple times #129

Closed
silkentrance opened this issue Jun 29, 2017 · 0 comments · May be fixed by mike-north/devcert#45 or sekikn/avro#9
Closed

tmp installs process listeners multiple times #129

silkentrance opened this issue Jun 29, 2017 · 0 comments · May be fixed by mike-north/devcert#45 or sekikn/avro#9
Assignees
Labels

Comments

@silkentrance
Copy link
Collaborator

silkentrance commented Jun 29, 2017

Operating System

  • all OS

NodeJS Version

  • all versions

Tmp Version

all versions

Expected Behavior

tmp must not try to install process exit and uncaughtException listeners multiple times.

Experienced Behavior

tmp installs listeners multiple times, causing a warning "possible event listener/memory leak".
This occurs when other projects use facebook/jest which removes and thus reloads existing modules during each test run. And it might also occur when using node's vm (sandboxed modules) API.

Rationale

Personally, I believe that facebook/jest is doing it wrong, but for the time being we should provide a work around for that problem.

As for node's sandbox VM module, we need to have additional tests that make sure that in such a scenario the listeners will not be added multiple times. Implementing such a test case properly will
require preventing tmp to install its listeners safely. Since this cannot be done, we will simply make sure that in a multiple sandbox environment the aforementioned warning will not be triggered.

In addition, we should notify the owners of dependent other projects of the update.
And, by analyzing the package dependencies of https://github.com/chrisprice/react-app-webdriver, the most prominent would be

  • makeerror
  • selenium-webdriver

See Also

#125

@silkentrance silkentrance self-assigned this Jun 29, 2017
silkentrance added a commit that referenced this issue Jul 6, 2017
fix #136 flaky tests for discardDescriptor option
silkentrance added a commit that referenced this issue Jul 6, 2017
fix #136 flaky tests for detachDescriptor option
silkentrance added a commit that referenced this issue Jul 8, 2017
fix #136 flaky tests for detachDescriptor option
silkentrance added a commit that referenced this issue Jul 8, 2017
fix #136 flaky tests for detachDescriptor option
silkentrance added a commit that referenced this issue Jul 8, 2017
fix #136 flaky tests for detachDescriptor option
silkentrance added a commit that referenced this issue Jul 8, 2017
silkentrance added a commit that referenced this issue Jul 8, 2017
silkentrance added a commit that referenced this issue Jul 8, 2017
silkentrance added a commit that referenced this issue Jul 8, 2017
silkentrance added a commit that referenced this issue Jul 8, 2017
silkentrance added a commit that referenced this issue Jul 8, 2017
silkentrance added a commit that referenced this issue Jul 8, 2017
silkentrance added a commit that referenced this issue Jul 8, 2017
fix #129 install process listeners safely
fix #139 flaky fd tests
silkentrance added a commit that referenced this issue Jul 10, 2017
silkentrance added a commit that referenced this issue Aug 16, 2017
silkentrance added a commit that referenced this issue Aug 16, 2017
also fixing footnotes as they will be interpreted as checkboxes
for tasks.
silkentrance added a commit that referenced this issue Aug 16, 2017
also fixing footnotes as they will be interpreted as checkboxes
for tasks.
silkentrance added a commit that referenced this issue Aug 16, 2017
silkentrance added a commit that referenced this issue Nov 28, 2017
silkentrance added a commit that referenced this issue Nov 28, 2017
silkentrance added a commit that referenced this issue Nov 29, 2017
add tests for #129
silkentrance added a commit that referenced this issue Nov 29, 2017
silkentrance added a commit that referenced this issue Nov 29, 2017
silkentrance added a commit that referenced this issue Nov 29, 2017
fix #129 install process listeners safely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant