Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling autounlock from menu fails [v1.6] #1458

Closed
shawnyeager opened this issue Aug 17, 2020 · 4 comments
Closed

Cancelling autounlock from menu fails [v1.6] #1458

shawnyeager opened this issue Aug 17, 2020 · 4 comments
Milestone
1.6.1 Release

Comments

@shawnyeager
Copy link

I was looking through the config options in menu, selected lnd autounlock, then, after being prompted to store the password on-device, selected cancel. The process continued anyway, confirming that autounlock is now active.
@rootzoll rootzoll added this to the 1.6.1 Release milestone Aug 17, 2020
@rootzoll
Copy link
Collaborator

rootzoll commented Aug 17, 2020 •
edited
Loading

Good find - will check the "CANCEL" option on that dialog for the next v1.6.1 service release.

@rootzoll rootzoll mentioned this issue Aug 24, 2020
Closed
@ChuckNorrison
Copy link
Contributor

cancel button in reboot dialogue will also result in a reboot and not cancel

@rootzoll
Copy link
Collaborator

@ChuckNorrison checked the reboot dialog on SSH main menu and it respects my cancel.
@shawnyeager found the problem in the auto-unlock cancel. Will be fixed in v1.6.1

@rootzoll rootzoll mentioned this issue Sep 15, 2020
Merged
rootzoll added a commit that referenced this issue Sep 15, 2020
@rootzoll
Fix problems with dialog CANCEL (#1548)
26a5285 
fixes for #1458 and #1482
rootzoll added a commit that referenced this issue Sep 15, 2020
@rootzoll
Fix problems with dialog CANCEL (#1548)
5f88652 
fixes for #1458 and #1482
@rootzoll rootzoll added the final testing was fixed - needs testing label Sep 15, 2020
@rootzoll
Copy link
Collaborator

OK Testing works. Will be part of v1.6.1 release .. closing issue.

@rootzoll rootzoll removed the final testing was fixed - needs testing label Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.1 Release
Development

No branches or pull requests
3 participants
@shawnyeager @rootzoll @ChuckNorrison