feat: add refresh address button for qr code #692
Conversation
|
Awesome, thank you very much! |
| ), | ||
| ); | ||
|
|
||
| const refreshBtn = await screen.findByRole("button", { |
There was a problem hiding this comment.
Looks like the test is failing - could you check that please? :)
There was a problem hiding this comment.
Hey @cstenglein , no worries at all. Happy to contribute, and hopefully there'll be a chance to keep helping out.
Interesting, I'm checking this one out. I noticed that there's an uncaught request going out, and I managed to catch it with a beforeEach instead of beforeAll at the beginning of these tests. However, it seems like the error is an "unknown login error" which does not seem to be happening when running the tests locally. Can you think of any reasons why that could be?
In any case, let's maybe see if this takes care of it.
There was a problem hiding this comment.
Well, it seems to have done the trick, right?
Let me know if there's anything else and I'll check it out. 🙂
There was a problem hiding this comment.
Yes, the reason is the useEffect hook in the ReceiveOnChain component, which fetches the new address at the start.
Looking good, merging, thank you!
jpyepez
force-pushed
the
feat/add-refresh-button-for-qr-code-431
branch
from
da8d65a to
9476ac7
Compare
| ), | ||
| ); | ||
|
|
||
| const refreshBtn = await screen.findByRole("button", { |
There was a problem hiding this comment.
Yes, the reason is the useEffect hook in the ReceiveOnChain component, which fetches the new address at the start.
Looking good, merging, thank you!
Description
This PR addresses issue #431
Screen Recording
This is a short demo of the resulting behaviour (with an overridden response, given that the mock backend seems to return the same address from the
new-addressendpoint).