Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a message when there are no storage devices. Fixes #798 #801

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

jedahan
Copy link

@jedahan jedahan commented Jan 31, 2024

Looks like I will need to learn qt/qml for work, thought I could start by contributing some small enhancements to rpi-imager.

empty-list.mov

I updated the message to say "No storage devices found" instead of 'nothing to see here'

@tdewey-rpi tdewey-rpi requested a review from maxnet February 1, 2024 16:31
@tdewey-rpi
Copy link
Collaborator

Thanks for the submission, @jedahan

Competently made, concise, and includes the translation hook! The only thing I could've asked for is to update the translation files so this string is marked 'untranslated' in non-English languages, but we can address that at a later point.

@tdewey-rpi
Copy link
Collaborator

Exceptional stuff, @jedahan. Thanks for the submission.

@tdewey-rpi tdewey-rpi merged commit cf9ceac into raspberrypi:qml Feb 5, 2024
@jedahan jedahan deleted the empty-storage-message branch February 5, 2024 16:30
@jedahan
Copy link
Author

jedahan commented Feb 5, 2024

Happy to make contributions, however small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants