-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some missing pio functions #2074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Nov 20, 2024
lurch
reviewed
Nov 20, 2024
lurch
reviewed
Nov 20, 2024
lurch
reviewed
Nov 20, 2024
lurch
reviewed
Nov 20, 2024
Adds some 64 versions to work with rp2350b and more than 32 pins. Change cyw43 code to use the new function. Fixes raspberrypi#1834
peterharperuk
force-pushed
the
pio64_funcs
branch
from
November 20, 2024 16:41
96a0353
to
bd89df1
Compare
merging this prior to some more PIO api cleanup I'm doing for > 32 pins, so it is possible it may change slightly |
kilograham
approved these changes
Nov 20, 2024
@kilograham When I do a full-build with
And indeed https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_platform_compiler/include/pico/platform/compiler.h#L63 says:
|
yeah, thanks, i will fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some 64 versions to work with rp2350b and more than 32 pins. Change cyw43 code to use the new function.
Fixes #1834