Async updates backport to 6.1 #5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vc4_plane_async_set_fb directly overwrites the plane address in the dlist entry, but hadn't been updated for the GEN6 / 2712 dlist format, corrupting the address in the process. Add support for the 2712 dlist format to the function. Fixes: 1ab1fbb ("drm/vc4: hvs: Support BCM2712 HVS") Signed-off-by: Dave Stevenson <[email protected]>
popcornmix
approved these changes
Jan 17, 2024
|
|
Missed getting the vc4 pointer here too. Updating. |
vc4_plane_atomic_async_check was always calling vc4_plane_mode_set to validate and generate the dlist for the check. If async_check decided it had to fall back to a sync commit, then this GEN4/5 dlist could get used on GEN6. Call either vc4_plane_mode_set or vc6_plane_mode_set as appropriate. Fixes: 1ab1fbb ("drm/vc4: hvs: Support BCM2712 HVS") Signed-off-by: Dave Stevenson <[email protected]>
6by9
force-pushed
the
rpi-6.1.y-dlists
branch
from
7feda63
to
969c5d8
Compare
|
Should be fixed now. |
|
Feel free to merge both of these when the build checks pass. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 18, 2024
kernel: drivers/gpu/drm/panel：Fixed display issues with several screens See: raspberrypi/linux#5818 kernel: Async updates backport to 6.1 See: raspberrypi/linux#5861
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 18, 2024
kernel: drivers/gpu/drm/panel：Fixed display issues with several screens See: raspberrypi/linux#5818 kernel: Async updates backport to 6.1 See: raspberrypi/linux#5861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5827 and #5860 backported to 6.1