Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CONFIG_JUMP_LABEL=y to defconfigs #348

Closed
wants to merge 1 commit into from
Closed

Added CONFIG_JUMP_LABEL=y to defconfigs #348

wants to merge 1 commit into from

Conversation

Ferroin
Copy link
Contributor

@Ferroin Ferroin commented Aug 5, 2013

This gives a generic performance boost to numerous parts of the kernel.
Even though this makes compile times slightly longer, native builds on
kernels with this running are faster than building without this option
on the official kernels.

@Ferroin
Added CONFIG_JUMP_LABEL=y to defconfigs
45f1882 
This gives a generic preformance boost to numerous parts of the kernel.
Even though this makes compile times slightly longer, native builds on
kernels with this running are faster than building without this option
on the official kernels.
@popcornmix
Copy link
Collaborator

Sound interesting.
Can you report any benchmarks that are improved with this change?

@Ferroin
Copy link
Contributor Author

Ferroin commented Aug 5, 2013

Networking latency is slightly reduced, my ping times drop from ~0.900ms to ~0.480ms with this enabled. True benchmarking though is kind of tricky because this only directly affects some parts of the kernel code. I also notice that many of the programs that I use that make lots of syscalls are faster with this enabled, disk I/O latency is slightly improved as well.

@Ferroin
Copy link
Contributor Author

Ferroin commented Aug 5, 2013

Just finished a bit more testing, boot times are reduced by about half a second on my current setup.
I realize of course that this probably isn't a major improvement, but on a low power system like the Pi, every little bit helps.

@popcornmix
Copy link
Collaborator

How about iperf?
Any affect on kernel size, or free memory after boot?
Are you aware of anything that runs slower?

@Ferroin
Copy link
Contributor Author

Ferroin commented Aug 5, 2013

Don't know if anything runs slower or not, I don't think so though.
I can check on iperf, but would need to install it first...
Free memory is about 4k less, kernel size is about 3k more uncompressed (less than 1k increase in zImage), difference is due to kernel memory size needing to be a multiple of page size.

@popcornmix
Copy link
Collaborator

I included this option on all kernel trees in last update. Thanks for suggestion.

@Ferroin
Copy link
Contributor Author

Ferroin commented Aug 17, 2013

I'm glad to provide what help I can.

@Ferroin Ferroin closed this Aug 17, 2013
@Ferroin Ferroin deleted the rpi-3.6.y-cfg-jump-label branch August 17, 2013 17:29
andyduller pushed a commit to afterthoughtsoftware/linux that referenced this pull request Oct 30, 2013
@popcornmix
Increase to CONFIG_MMC_BLOCK_MINORS=32
70bf851 
and enable CONFIG_JUMP_LABEL
See: raspberrypi#348
lwfinger pushed a commit to lwfinger/linux that referenced this pull request Nov 10, 2013
@popcornmix
Increase to CONFIG_MMC_BLOCK_MINORS=32
c9248e0 
and enable CONFIG_JUMP_LABEL
See: raspberrypi#348
davet321 pushed a commit to davet321/rpi-linux that referenced this pull request Nov 18, 2013
@popcornmix
Increase to CONFIG_MMC_BLOCK_MINORS=32
b8c9cb9 
and enable CONFIG_JUMP_LABEL
See: raspberrypi#348
davet321 pushed a commit to davet321/rpi-linux that referenced this pull request Nov 18, 2013
@popcornmix
Add config options
6fe5936 
Increase to CONFIG_MMC_BLOCK_MINORS=32
and enable CONFIG_JUMP_LABEL
See: raspberrypi#348

Move to SLUB memory allocator.
See: raspberrypi#349
chinasaur pushed a commit to chinasaur/firmware that referenced this pull request Aug 3, 2014
Increase to CONFIG_MMC_BLOCK_MINORS=32
e0590d6 
and enable CONFIG_JUMP_LABEL
See: raspberrypi/linux#348

raspicam: Added -roi command to allow specification of the area of the sensor to use as input
See: raspberrypi/userland#73
neuschaefer pushed a commit to neuschaefer/raspi-binary-firmware that referenced this pull request Feb 27, 2017
Increase to CONFIG_MMC_BLOCK_MINORS=32
f4e366a 
and enable CONFIG_JUMP_LABEL
See: raspberrypi/linux#348

raspicam: Added -roi command to allow specification of the area of the sensor to use as input
See: raspberrypi/userland#73
popcornmix pushed a commit that referenced this pull request Mar 23, 2020
@ummakynes @gregkh
netfilter: nft_chain_nat: inet family is missing module ownership
2d106e7 
commit 6a42cef upstream.

Set owner to THIS_MODULE, otherwise the nft_chain_nat module might be
removed while there are still inet/nat chains in place.

[  117.942096] BUG: unable to handle page fault for address: ffffffffa0d5e040
[  117.942101] #PF: supervisor read access in kernel mode
[  117.942103] #PF: error_code(0x0000) - not-present page
[  117.942106] PGD 200c067 P4D 200c067 PUD 200d063 PMD 3dc909067 PTE 0
[  117.942113] Oops: 0000 [#1] PREEMPT SMP PTI
[  117.942118] CPU: 3 PID: 27 Comm: kworker/3:0 Not tainted 5.6.0-rc3+ #348
[  117.942133] Workqueue: events nf_tables_trans_destroy_work [nf_tables]
[  117.942145] RIP: 0010:nf_tables_chain_destroy.isra.0+0x94/0x15a [nf_tables]
[  117.942149] Code: f6 45 54 01 0f 84 d1 00 00 00 80 3b 05 74 44 48 8b 75 e8 48 c7 c7 72 be de a0 e8 56 e6 2d e0 48 8b 45 e8 48 c7 c7 7f be de a0 <48> 8b 30 e8 43 e6 2d e0 48 8b 45 e8 48 8b 40 10 48 85 c0 74 5b 8b
[  117.942152] RSP: 0018:ffffc9000015be10 EFLAGS: 00010292
[  117.942155] RAX: ffffffffa0d5e040 RBX: ffff88840be87fc2 RCX: 0000000000000007
[  117.942158] RDX: 0000000000000007 RSI: 0000000000000086 RDI: ffffffffa0debe7f
[  117.942160] RBP: ffff888403b54b50 R08: 0000000000001482 R09: 0000000000000004
[  117.942162] R10: 0000000000000000 R11: 0000000000000001 R12: ffff8883eda7e540
[  117.942164] R13: dead000000000122 R14: dead000000000100 R15: ffff888403b3db80
[  117.942167] FS:  0000000000000000(0000) GS:ffff88840e4c0000(0000) knlGS:0000000000000000
[  117.942169] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  117.942172] CR2: ffffffffa0d5e040 CR3: 00000003e4c52002 CR4: 00000000001606e0
[  117.942174] Call Trace:
[  117.942188]  nf_tables_trans_destroy_work.cold+0xd/0x12 [nf_tables]
[  117.942196]  process_one_work+0x1d6/0x3b0
[  117.942200]  worker_thread+0x45/0x3c0
[  117.942203]  ? process_one_work+0x3b0/0x3b0
[  117.942210]  kthread+0x112/0x130
[  117.942214]  ? kthread_create_worker_on_cpu+0x40/0x40
[  117.942221]  ret_from_fork+0x35/0x40

nf_tables_chain_destroy() crashes on module_put() because the module is
gone.

Fixes: d164385 ("netfilter: nat: add inet family nat support")
Signed-off-by: Pablo Neira Ayuso <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
popcornmix pushed a commit that referenced this pull request Mar 23, 2020
@ummakynes @gregkh
netfilter: nft_chain_nat: inet family is missing module ownership
19accea 
commit 6a42cef upstream.

Set owner to THIS_MODULE, otherwise the nft_chain_nat module might be
removed while there are still inet/nat chains in place.

[  117.942096] BUG: unable to handle page fault for address: ffffffffa0d5e040
[  117.942101] #PF: supervisor read access in kernel mode
[  117.942103] #PF: error_code(0x0000) - not-present page
[  117.942106] PGD 200c067 P4D 200c067 PUD 200d063 PMD 3dc909067 PTE 0
[  117.942113] Oops: 0000 [#1] PREEMPT SMP PTI
[  117.942118] CPU: 3 PID: 27 Comm: kworker/3:0 Not tainted 5.6.0-rc3+ #348
[  117.942133] Workqueue: events nf_tables_trans_destroy_work [nf_tables]
[  117.942145] RIP: 0010:nf_tables_chain_destroy.isra.0+0x94/0x15a [nf_tables]
[  117.942149] Code: f6 45 54 01 0f 84 d1 00 00 00 80 3b 05 74 44 48 8b 75 e8 48 c7 c7 72 be de a0 e8 56 e6 2d e0 48 8b 45 e8 48 c7 c7 7f be de a0 <48> 8b 30 e8 43 e6 2d e0 48 8b 45 e8 48 8b 40 10 48 85 c0 74 5b 8b
[  117.942152] RSP: 0018:ffffc9000015be10 EFLAGS: 00010292
[  117.942155] RAX: ffffffffa0d5e040 RBX: ffff88840be87fc2 RCX: 0000000000000007
[  117.942158] RDX: 0000000000000007 RSI: 0000000000000086 RDI: ffffffffa0debe7f
[  117.942160] RBP: ffff888403b54b50 R08: 0000000000001482 R09: 0000000000000004
[  117.942162] R10: 0000000000000000 R11: 0000000000000001 R12: ffff8883eda7e540
[  117.942164] R13: dead000000000122 R14: dead000000000100 R15: ffff888403b3db80
[  117.942167] FS:  0000000000000000(0000) GS:ffff88840e4c0000(0000) knlGS:0000000000000000
[  117.942169] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  117.942172] CR2: ffffffffa0d5e040 CR3: 00000003e4c52002 CR4: 00000000001606e0
[  117.942174] Call Trace:
[  117.942188]  nf_tables_trans_destroy_work.cold+0xd/0x12 [nf_tables]
[  117.942196]  process_one_work+0x1d6/0x3b0
[  117.942200]  worker_thread+0x45/0x3c0
[  117.942203]  ? process_one_work+0x3b0/0x3b0
[  117.942210]  kthread+0x112/0x130
[  117.942214]  ? kthread_create_worker_on_cpu+0x40/0x40
[  117.942221]  ret_from_fork+0x35/0x40

nf_tables_chain_destroy() crashes on module_put() because the module is
gone.

Fixes: d164385 ("netfilter: nat: add inet family nat support")
Signed-off-by: Pablo Neira Ayuso <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
popcornmix pushed a commit that referenced this pull request Mar 23, 2020
@ummakynes
netfilter: nft_chain_nat: inet family is missing module ownership
6a42cef 
Set owner to THIS_MODULE, otherwise the nft_chain_nat module might be
removed while there are still inet/nat chains in place.

[  117.942096] BUG: unable to handle page fault for address: ffffffffa0d5e040
[  117.942101] #PF: supervisor read access in kernel mode
[  117.942103] #PF: error_code(0x0000) - not-present page
[  117.942106] PGD 200c067 P4D 200c067 PUD 200d063 PMD 3dc909067 PTE 0
[  117.942113] Oops: 0000 [#1] PREEMPT SMP PTI
[  117.942118] CPU: 3 PID: 27 Comm: kworker/3:0 Not tainted 5.6.0-rc3+ #348
[  117.942133] Workqueue: events nf_tables_trans_destroy_work [nf_tables]
[  117.942145] RIP: 0010:nf_tables_chain_destroy.isra.0+0x94/0x15a [nf_tables]
[  117.942149] Code: f6 45 54 01 0f 84 d1 00 00 00 80 3b 05 74 44 48 8b 75 e8 48 c7 c7 72 be de a0 e8 56 e6 2d e0 48 8b 45 e8 48 c7 c7 7f be de a0 <48> 8b 30 e8 43 e6 2d e0 48 8b 45 e8 48 8b 40 10 48 85 c0 74 5b 8b
[  117.942152] RSP: 0018:ffffc9000015be10 EFLAGS: 00010292
[  117.942155] RAX: ffffffffa0d5e040 RBX: ffff88840be87fc2 RCX: 0000000000000007
[  117.942158] RDX: 0000000000000007 RSI: 0000000000000086 RDI: ffffffffa0debe7f
[  117.942160] RBP: ffff888403b54b50 R08: 0000000000001482 R09: 0000000000000004
[  117.942162] R10: 0000000000000000 R11: 0000000000000001 R12: ffff8883eda7e540
[  117.942164] R13: dead000000000122 R14: dead000000000100 R15: ffff888403b3db80
[  117.942167] FS:  0000000000000000(0000) GS:ffff88840e4c0000(0000) knlGS:0000000000000000
[  117.942169] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  117.942172] CR2: ffffffffa0d5e040 CR3: 00000003e4c52002 CR4: 00000000001606e0
[  117.942174] Call Trace:
[  117.942188]  nf_tables_trans_destroy_work.cold+0xd/0x12 [nf_tables]
[  117.942196]  process_one_work+0x1d6/0x3b0
[  117.942200]  worker_thread+0x45/0x3c0
[  117.942203]  ? process_one_work+0x3b0/0x3b0
[  117.942210]  kthread+0x112/0x130
[  117.942214]  ? kthread_create_worker_on_cpu+0x40/0x40
[  117.942221]  ret_from_fork+0x35/0x40

nf_tables_chain_destroy() crashes on module_put() because the module is
gone.

Fixes: d164385 ("netfilter: nat: add inet family nat support")
Signed-off-by: Pablo Neira Ayuso <[email protected]>
jai-raptee pushed a commit to jai-raptee/iliteck1 that referenced this pull request Apr 30, 2024
@popcornmix
Increase to CONFIG_MMC_BLOCK_MINORS=32
f8305c8 
and enable CONFIG_JUMP_LABEL
See: raspberrypi/linux#348
popcornmix pushed a commit that referenced this pull request Jun 3, 2024
@borkmann
selftests/bpf: Add netkit test for pkt_type
95348e4 
Add a test case to assert that the skb->pkt_type which was set from the BPF
program is retained from the netkit xmit side to the peer's device at tcx
ingress location.

  # ./vmtest.sh -- ./test_progs -t netkit
  [...]
  ./test_progs -t netkit
  [    1.140780] bpf_testmod: loading out-of-tree module taints kernel.
  [    1.141127] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel
  [    1.284601] tsc: Refined TSC clocksource calibration: 3408.006 MHz
  [    1.286672] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x311fd9b189d, max_idle_ns: 440795225691 ns
  [    1.290384] clocksource: Switched to clocksource tsc
  #345     tc_netkit_basic:OK
  #346     tc_netkit_device:OK
  #347     tc_netkit_multi_links:OK
  #348     tc_netkit_multi_opts:OK
  #349     tc_netkit_neigh_links:OK
  #350     tc_netkit_pkt_type:OK
  Summary: 6/0 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Daniel Borkmann <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Alexei Starovoitov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ferroin @popcornmix