Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALSA: usb-audio: Add Gustard U16/X26 to quirks for native DSD support #3295

Closed
wants to merge 1 commit into from

Conversation

montaintop
Copy link

ALSA: usb-audio: Add Gustard U16/X26 to quirks for native DSD support

ALSA: usb-audio: Add Gustard U16/X26 to quirks for native DSD support
@pelwell
Copy link
Contributor

pelwell commented Oct 22, 2019

This patch should go upstream, but first you'll need to fix the issues identified by checkpatch:

ERROR: trailing whitespace
#20: FILE: sound/usb/quirks.c:1372:
+ ^Icase USB_ID(0x292b, 0xc4b3): /* Gustard U16/X26 USB Interface */^I$

ERROR: code indent should use tabs where possible
#20: FILE: sound/usb/quirks.c:1372:
+ ^Icase USB_ID(0x292b, 0xc4b3): /* Gustard U16/X26 USB Interface */^I$

WARNING: please, no space before tabs
#20: FILE: sound/usb/quirks.c:1372:
+ ^Icase USB_ID(0x292b, 0xc4b3): /* Gustard U16/X26 USB Interface */^I$

WARNING: please, no spaces at the start of a line
#20: FILE: sound/usb/quirks.c:1372:
+ ^Icase USB_ID(0x292b, 0xc4b3): /* Gustard U16/X26 USB Interface */^I$

ERROR: Missing Signed-off-by: line(s)

total: 3 errors, 3 warnings, 7 lines checked

When you are ready, email it to:

Jaroslav Kysela <[email protected]>
Takashi Iwai <[email protected]>
Greg Kroah-Hartman <[email protected]>
[email protected]

@montaintop
Copy link
Author

Hi There

Mr. Iwai approved with slight change, in the following commit, possible to pull it in here?

@@ -1657,6 +1657,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio chip,
case 0x23ba: /
Playback Designs /
case 0x25ce: /
Mytek devices /
case 0x278b: /
Rotel? /
case 0x292b: /
Gustard/Ess based devices /
case 0x2ab6: /
T+A devices /
case 0x3842: /
EVGA /
case 0xc502: /
HiBy devices */

tiwai/sound@e2995b9

@pelwell
Copy link
Contributor

pelwell commented Oct 24, 2019

Give me a nudge when it hits linux-next (https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git), which should be tomorrow.

@montaintop
Copy link
Author

@pelwell
Copy link
Contributor

pelwell commented Oct 25, 2019

See e6be45a.

@montaintop montaintop closed this Oct 25, 2019
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Oct 28, 2019
See: raspberrypi/linux#3296

kernel: dts: bcm2838: Disable DWC OTG block by default

kernel: ALSA: usb-audio: Add Gustard U16/X26 to quirks for native DSD support
See: raspberrypi/linux#3295

kernel: bcm2835-v4l2-codec fixes
See: raspberrypi/linux#3293

kernel: drm:vc4 Added calls for firmware display blank/unblank
See: raspberrypi/linux#3289

firmware: arm_loader: Fix explicit kernel name handling
See: #1277

firmware: Added a new display power mailbox call
firmware: Update display_power gencmd with optional display id
See: raspberrypi/linux#3050

firmware: Remove legacy pkgconfig to avoid Mesa conflicts
See: raspberrypi/userland#585
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Oct 28, 2019
See: raspberrypi/linux#3296

kernel: dts: bcm2838: Disable DWC OTG block by default

kernel: ALSA: usb-audio: Add Gustard U16/X26 to quirks for native DSD support
See: raspberrypi/linux#3295

kernel: bcm2835-v4l2-codec fixes
See: raspberrypi/linux#3293

kernel: drm:vc4 Added calls for firmware display blank/unblank
See: raspberrypi/linux#3289

firmware: arm_loader: Fix explicit kernel name handling
See: raspberrypi/firmware#1277

firmware: Added a new display power mailbox call
firmware: Update display_power gencmd with optional display id
See: raspberrypi/linux#3050

firmware: Remove legacy pkgconfig to avoid Mesa conflicts
See: raspberrypi/userland#585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants