RFC: sound: Fixes for audioinjector-octo under 4.19 #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any feedback for this patch? |
1. Move the DT alias declaration to the I2C shim in the cases where the shim is enabled. This works around a problem caused by a 4.19 commit [1] that generates DT/OF uevents for I2C drivers. 2. Fix the diagnostics in an error path of the soundcard driver to correctly identify the reason for the failure to load. 3. Move the declaration of the clock node in the overlay outside the I2C node to avoid warnings. 4. Sort the overlay nodes so that dependencies are only to earlier fragments, in an attempt to get runtime dtoverlay application to work (it still doesn't...) See: Audio-Injector/Octo#14 Signed-off-by: Phil Elwell <[email protected]> [1] af50371 ("i2c: core: report OF style module alias for devices registered via OF")
|
Rebased. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Apr 23, 2019
kernel: audioinjector-octo: revert to dummy supplies See: raspberrypi/linux#2834 kernel: sound: Fixes for audioinjector-octo under 4.19 See: raspberrypi/linux#2902 kernel: Maxim MAX98357A I2S DAC overlay See: raspberrypi/linux#2935 kernel: Add DVBSky S960 patch to fix broken driver See: raspberrypi/linux#2849
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Apr 23, 2019
kernel: audioinjector-octo: revert to dummy supplies See: raspberrypi/linux#2834 kernel: sound: Fixes for audioinjector-octo under 4.19 See: raspberrypi/linux#2902 kernel: Maxim MAX98357A I2S DAC overlay See: raspberrypi/linux#2935 kernel: Add DVBSky S960 patch to fix broken driver See: raspberrypi/linux#2849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the DT alias declaration to the I2C shim in the cases
where the shim is enabled. This works around a problem caused by a
4.19 commit [1] that generates DT/OF uevents for I2C drivers.
Fix the diagnostics in an error path of the soundcard driver to
correctly identify the reason for the failure to load.
Move the declaration of the clock node in the overlay outside
the I2C node to avoid warnings.
Sort the overlay nodes so that dependencies are only to earlier
fragments, in an attempt to get runtime dtoverlay application to
work (it still doesn't...)
See: Audio-Injector/Octo#14
Signed-off-by: Phil Elwell [email protected]
[1] af50371 ("i2c: core: report OF style module alias for devices registered via OF")