Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends" #2717

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

6by9
Copy link
Contributor

@6by9 6by9 commented Oct 15, 2018

This reverts commit 6bf32cd.

Various people have been reporting seeing "eth0: hw csum failure"
and callstacks dumped in the kernel log on 4.18, and since 4.14.71,
on both SMSC9514 and LAN7800 adapters.
This commit appears to be the reason, but potentially due to an
issue further down the stack. Revert whilst investigating the
trigger.

#2713
#2659
#2712

Signed-off-by: Dave Stevenson [email protected]

This reverts commit 6bf32cd.

Various people have been reporting seeing "eth0: hw csum failure"
and callstacks dumped in the kernel log on 4.18, and since 4.14.71,
on both SMSC9514 and LAN7800 adapters.
This commit appears to be the reason, but potentially due to an
issue further down the stack. Revert whilst investigating the
trigger.

raspberrypi#2713
raspberrypi#2659
raspberrypi#2712

Signed-off-by: Dave Stevenson <[email protected]>
@6by9
Copy link
Contributor Author

6by9 commented Oct 15, 2018

@pelwell revert for 4.14 as discussed.

@pelwell pelwell merged commit 4a098c7 into raspberrypi:rpi-4.14.y Oct 15, 2018
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Oct 15, 2018
kernel: Revert net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends
See: raspberrypi/linux#2717

kernel: thermal: add hysteresis support and adjust PoE HAT trip points
See: raspberrypi/linux#2700

kernel: Add composite RPi driver for pcm512x DAC HAT cards
See: raspberrypi/linux#2702

firmware: jpeg/mjpeg: MJPEG doesn't insert JFIF APP0 header
See: raspberrypi/userland#345

firmware: Add IL HVS component

firmware: mmal: Acquire zero copy buffers on being passed to the VPU

firmware: video_render: Use per pixel alpha on RGBA and BGRA

firmware: video_render: Add support for alpha options (MIX and PREMULT)
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Oct 15, 2018
kernel: Revert net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends
See: raspberrypi/linux#2717

kernel: thermal: add hysteresis support and adjust PoE HAT trip points
See: raspberrypi/linux#2700

kernel: Add composite RPi driver for pcm512x DAC HAT cards
See: raspberrypi/linux#2702

firmware: jpeg/mjpeg: MJPEG doesn't insert JFIF APP0 header
See: raspberrypi/userland#345

firmware: Add IL HVS component

firmware: mmal: Acquire zero copy buffers on being passed to the VPU

firmware: video_render: Use per pixel alpha on RGBA and BGRA

firmware: video_render: Add support for alpha options (MIX and PREMULT)
@jens-maus
Copy link

jens-maus commented Oct 27, 2018

@pelwell Now that other projects (see jens-maus/RaspberryMatic#449) are facing the same issue, when will you release a new official raspberrypi-kernel_1.2018XXXX-1 version (including corresponding Pi-firmware) these projects can pick up?

@popcornmix
Copy link
Collaborator

ping @XECDesign who deals with stable apt releases.
The upstream fix is on 4.19 kernel tree but hasn't reached 4.14. I suspect it will appear on next minor kernel bump (probably this week), and that may be a good point to bump the apt kernel.

@popcornmix
Copy link
Collaborator

Latest rpi-update kernel removes this revert and makes use of the upstream fix.

@jens-maus
Copy link

@popcornmix Then where are the proper tagged version in raspberrypi/linux and raspberrypi/firmware? I can only see the 20180924 versions there.

@popcornmix
Copy link
Collaborator

@jens-maus Tagged versions won't appear until kernel/firmware is updated in apt.
This is still in rpi-update testing. If we get positive reports the apt version will be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants