-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overlay for ads1115 ADCs #1864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the README nitpicks, this looks good.
arch/arm/boot/dts/overlays/README
Outdated
@@ -196,6 +196,28 @@ Params: addr I2C bus address of device. Set based on how the | |||
http://www.ti.com/lit/ds/symlink/ads1015.pdf | |||
|
|||
|
|||
Name: ads1115 | |||
Info: Texas Instruments ADS1115 ADC | |||
Load: dtoverlay=ads1115,<param>[=<val>] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preceding three lines need one extra space each to get the indent right.
arch/arm/boot/dts/overlays/README
Outdated
addr pin is wired. (default=0x48 assumes addr | ||
is pulled to GND) | ||
cha_enable Enable virtual channel a. | ||
cha_mux Set the input mux for virtual channel a. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this what the overlay calls cha_cfg? They need to match.
arch/arm/boot/dts/overlays/README
Outdated
cha_mux Set the input mux for virtual channel a. | ||
(default=4 configures this channel for the | ||
voltage at A0 with respect to GND) | ||
cha_rate Set the datarate (samples/sec) for this channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another mismatch - rate<->datarate.
kernel: BCM2835-V4L2: Correctly denote key frames in encoded data kernel: bcm2835-gpio-exp: Driver for GPIO expander via mailbox service See: raspberrypi/linux#1852 kernel: Add overlay for ads1115 ADCs See: raspberrypi/linux#1864 kernel: Add support for Fe-Pi audio sound card See: raspberrypi/linux#1867 kernel: amba_pl011: Round input clock up kernel: clk-bcm2835: Correct the prediv logic firmware: Redo CEC code cleanup 3: Removed CEC topology computation firmware: Redo CEC code cleanup 4: Removed unused functions firmware: Redo CEC code cleanup 5: Removed Rx processing firmware: Redo CEC code cleanup 6: Logging changed to VCOS firmware: Redo CEC code cleanup 7: Removed hdmi_state_machine_clock_changed firmware: Redo CEC code cleanup 8: fixed hdmi state machine clk firmware: Redo CEC code cleanup 10: misc cosmetic changes firmware: Fixup CEC code cleanup 8: fixed hdmi state machine clk firmware: hdmi: Add way of forcing logging for hdmi and cec from boot firmware: Redo CEC code cleanup 11: cec_release_logical_addr firmware: arm_loader: Respect smsc95xx.macaddr parameter See: raspberrypi/linux#1865 firmware: vec: Fix progressive scan composite mode See: #683 firmware: vec: PAL_M mode is 525/60 See: #756 firmware: IL ISP: Support Bayer firmware: IL ISP: Fix error in stride calcs for YUYV formats firmware: video_render: buffer size fixup for ARGB888 firmware: video_render: Support per-pixel alpha on RGBA input See: waveform80/picamera#199
kernel: BCM2835-V4L2: Correctly denote key frames in encoded data kernel: bcm2835-gpio-exp: Driver for GPIO expander via mailbox service See: raspberrypi/linux#1852 kernel: Add overlay for ads1115 ADCs See: raspberrypi/linux#1864 kernel: Add support for Fe-Pi audio sound card See: raspberrypi/linux#1867 kernel: amba_pl011: Round input clock up kernel: clk-bcm2835: Correct the prediv logic firmware: Redo CEC code cleanup 3: Removed CEC topology computation firmware: Redo CEC code cleanup 4: Removed unused functions firmware: Redo CEC code cleanup 5: Removed Rx processing firmware: Redo CEC code cleanup 6: Logging changed to VCOS firmware: Redo CEC code cleanup 7: Removed hdmi_state_machine_clock_changed firmware: Redo CEC code cleanup 8: fixed hdmi state machine clk firmware: Redo CEC code cleanup 10: misc cosmetic changes firmware: Fixup CEC code cleanup 8: fixed hdmi state machine clk firmware: hdmi: Add way of forcing logging for hdmi and cec from boot firmware: Redo CEC code cleanup 11: cec_release_logical_addr firmware: arm_loader: Respect smsc95xx.macaddr parameter See: raspberrypi/linux#1865 firmware: vec: Fix progressive scan composite mode See: raspberrypi/firmware#683 firmware: vec: PAL_M mode is 525/60 See: raspberrypi/firmware#756 firmware: IL ISP: Support Bayer firmware: IL ISP: Fix error in stride calcs for YUYV formats firmware: video_render: buffer size fixup for ARGB888 firmware: video_render: Support per-pixel alpha on RGBA input See: waveform80/picamera#199
kernel: BCM2835-V4L2: Correctly denote key frames in encoded data kernel: bcm2835-gpio-exp: Driver for GPIO expander via mailbox service See: raspberrypi/linux#1852 kernel: Add overlay for ads1115 ADCs See: raspberrypi/linux#1864 kernel: Add support for Fe-Pi audio sound card See: raspberrypi/linux#1867 kernel: amba_pl011: Round input clock up kernel: clk-bcm2835: Correct the prediv logic firmware: Redo CEC code cleanup 3: Removed CEC topology computation firmware: Redo CEC code cleanup 4: Removed unused functions firmware: Redo CEC code cleanup 5: Removed Rx processing firmware: Redo CEC code cleanup 6: Logging changed to VCOS firmware: Redo CEC code cleanup 7: Removed hdmi_state_machine_clock_changed firmware: Redo CEC code cleanup 8: fixed hdmi state machine clk firmware: Redo CEC code cleanup 10: misc cosmetic changes firmware: Fixup CEC code cleanup 8: fixed hdmi state machine clk firmware: hdmi: Add way of forcing logging for hdmi and cec from boot firmware: Redo CEC code cleanup 11: cec_release_logical_addr firmware: arm_loader: Respect smsc95xx.macaddr parameter See: raspberrypi/linux#1865 firmware: vec: Fix progressive scan composite mode See: #683 firmware: vec: PAL_M mode is 525/60 See: #756 firmware: IL ISP: Support Bayer firmware: IL ISP: Fix error in stride calcs for YUYV formats firmware: video_render: buffer size fixup for ARGB888 firmware: video_render: Support per-pixel alpha on RGBA input See: waveform80/picamera#199
kernel: BCM2835-V4L2: Correctly denote key frames in encoded data kernel: bcm2835-gpio-exp: Driver for GPIO expander via mailbox service See: raspberrypi/linux#1852 kernel: Add overlay for ads1115 ADCs See: raspberrypi/linux#1864 kernel: Add support for Fe-Pi audio sound card See: raspberrypi/linux#1867 kernel: amba_pl011: Round input clock up kernel: clk-bcm2835: Correct the prediv logic firmware: Redo CEC code cleanup 3: Removed CEC topology computation firmware: Redo CEC code cleanup 4: Removed unused functions firmware: Redo CEC code cleanup 5: Removed Rx processing firmware: Redo CEC code cleanup 6: Logging changed to VCOS firmware: Redo CEC code cleanup 7: Removed hdmi_state_machine_clock_changed firmware: Redo CEC code cleanup 8: fixed hdmi state machine clk firmware: Redo CEC code cleanup 10: misc cosmetic changes firmware: Fixup CEC code cleanup 8: fixed hdmi state machine clk firmware: hdmi: Add way of forcing logging for hdmi and cec from boot firmware: Redo CEC code cleanup 11: cec_release_logical_addr firmware: arm_loader: Respect smsc95xx.macaddr parameter See: raspberrypi/linux#1865 firmware: vec: Fix progressive scan composite mode See: raspberrypi/firmware#683 firmware: vec: PAL_M mode is 525/60 See: raspberrypi/firmware#756 firmware: IL ISP: Support Bayer firmware: IL ISP: Fix error in stride calcs for YUYV formats firmware: video_render: buffer size fixup for ARGB888 firmware: video_render: Support per-pixel alpha on RGBA input See: waveform80/picamera#199
kernel: BCM270X_DT: Invert Pi3 power LED to match fw change See: raspberrypi/linux#1879 kernel: Add support for the AudioInjector Octo sound card See: raspberrypi/linux#1884 kernel: Fix gadget mode for bcm2835 See: raspberrypi/linux#1887 kernel: bcm2835-v4l2: Fix buffer overflow problem See: raspberrypi/linux#1890 kernel: Add support for Fe-Pi audio sound card See: raspberrypi/linux#1867 kernel: BCM270X_DT: Flip the polarity of the CM3's HDMI HPD See: raspberrypi/linux#1869 kernel: Add overlay for ads1115 ADCs See: raspberrypi/linux#1864 kernel: config: Add CONFIG_CRYPTO_LZ4 See: raspberrypi/linux#1875 kernel: clk-bcm2835: Read max core clock from firmware firmware: GPIO expander: rework so the mailbox service reads raw values firmware: arm_loader: Check GPIO direction for low_voltage See: raspberrypi/linux#1879 firmware: warnings: Fix some mostly spurious warnings firmware: clock: Calculate PLL multipliers with more precision firmware: Set up HDMI VCO same for VEC as for HDMI firmeare: gpu_server: Move detailed logging to LOGGING_VMCS_VERBOSE category
kernel: BCM270X_DT: Invert Pi3 power LED to match fw change See: raspberrypi/linux#1879 kernel: Add support for the AudioInjector Octo sound card See: raspberrypi/linux#1884 kernel: Fix gadget mode for bcm2835 See: raspberrypi/linux#1887 kernel: bcm2835-v4l2: Fix buffer overflow problem See: raspberrypi/linux#1890 kernel: Add support for Fe-Pi audio sound card See: raspberrypi/linux#1867 kernel: BCM270X_DT: Flip the polarity of the CM3's HDMI HPD See: raspberrypi/linux#1869 kernel: Add overlay for ads1115 ADCs See: raspberrypi/linux#1864 kernel: config: Add CONFIG_CRYPTO_LZ4 See: raspberrypi/linux#1875 kernel: clk-bcm2835: Read max core clock from firmware firmware: GPIO expander: rework so the mailbox service reads raw values firmware: arm_loader: Check GPIO direction for low_voltage See: raspberrypi/linux#1879 firmware: warnings: Fix some mostly spurious warnings firmware: clock: Calculate PLL multipliers with more precision firmware: Set up HDMI VCO same for VEC as for HDMI firmeare: gpu_server: Move detailed logging to LOGGING_VMCS_VERBOSE category
The ads1015 kernel driver supports ads1015 and ads1115 devices but different data rate tables are used internally based on the device. The data rate tables are used to calculate timeouts.