Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlays symlink and dtbo tagert for ARM64 #1739

Merged
merged 2 commits into from
Dec 2, 2016
Merged

Add overlays symlink and dtbo tagert for ARM64 #1739

merged 2 commits into from
Dec 2, 2016

Conversation

Gerharddc
Copy link

This patch symlinks the overlays directory into ARM64 and adds the dtbo target needed to build them to the ARm64 makefile.

Signed-off-by: Gerhard de Clercq [email protected]

@Gerharddc Gerharddc mentioned this pull request Dec 2, 2016
@pelwell
Copy link
Contributor

pelwell commented Dec 2, 2016

I have a few problems with this commit:

  1. I'm not wildly keen on the symlink, but it isn't the first and I haven't thought of a better way yet, so I'm not going to object for that reason.

  2. I think the symlink belongs in the broadcom directory, since they are Broadcom platform-specific. This then has the problem that the dtbs_install put them into broadcom/overlays/, but we have to solve that problem for the base dtbs.

  3. You still need to add overlays to subdirs-y, otherwise the directory is never visited.

I'm prepared to overlook 1 and 2 and treat this is a stepping stone, but 3 needs to be fixed.

@Gerharddc
Copy link
Author

I also don't like the symlink but yeah what else. I see that some of the dts files in the broadcom directory actually just include the normal files in the arm folder themselves but I find this even less satisfying...

I agree that the overlays should be in the broadcom folder but this will be horrible for build systems until the problem of the broadcom folder is solved. Luckily my system can easily be made to fetch the base dtbs from there but not overlays.

I didn't even notice the subdris-y problem because my system builds the overlays manually. I'll quickly add that.

@pelwell pelwell merged commit 9c99e35 into raspberrypi:rpi-4.8.y Dec 2, 2016
@pelwell
Copy link
Contributor

pelwell commented Dec 2, 2016

Thanks - I've squashed and merged your commits.

popcornmix pushed a commit that referenced this pull request Dec 2, 2016
popcornmix pushed a commit that referenced this pull request Dec 9, 2016
popcornmix pushed a commit that referenced this pull request Dec 15, 2016
popcornmix pushed a commit that referenced this pull request Dec 19, 2016
popcornmix pushed a commit that referenced this pull request Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants