Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two issues after upgrade. #462

Closed
kukabu opened this issue Dec 12, 2013 · 6 comments
Closed

Two issues after upgrade. #462

kukabu opened this issue Dec 12, 2013 · 6 comments

Comments

@kukabu
Copy link

kukabu commented Dec 12, 2013

Hello
Today I updated the Raspbian and I found two small issues.

  1. The ax88179_178a is builded in kernel now. why?
    $ zcat /proc/config.gz | fgrep -i ax88179
    CONFIG_USB_NET_AX88179_178A=y
  2. I guess now isn't properly considered the BogoMIPS.
    Calibrating delay loop (skipped), value calculated using timer frequency.. 2.00 BogoMIPS (lpj=10000)

$ cat /proc/version
Linux version 3.10.23+ (dc4@dc4-arm-01) (gcc version 4.7.2 20120731 (prerelease) (crosstool-NG linaro-1.13.1+bzr2458 - Linaro GCC 2012.08) ) #608 PREEMPT Mon Dec 9 21:11:23 GMT 2013
$ vcgencmd version
Dec 9 2013 21:22:17
Copyright (c) 2012 Broadcom
version c7215df85576f3e72f9c390db9bc2da642453b10 (clean) (release)
@kukabu
Copy link
Author

kukabu commented Dec 12, 2013

also xpad is builded in kernel.
$ zcat /proc/config.gz | fgrep -i xpad
CONFIG_JOYSTICK_XPAD=y
CONFIG_JOYSTICK_XPAD_FF=y

I think the ax88179 and xpad must be modules.

@licaon-kter
Copy link

Regarding issue 1: #225 (comment)

Any reason you want those (xpad, ax88179) as modules?

@popcornmix
Copy link
Collaborator

Agree with 1. No good reason for the "=y". Will make them modules.
For 2. see #225 (comment).

@kukabu
Copy link
Author

kukabu commented Dec 12, 2013

thanks

popcornmix pushed a commit to raspberrypi/firmware that referenced this issue Dec 12, 2013
kernel: bump to 3.10.24
e618d4f 
kernel: Make USB_NET_AX88179_178A and JOYSTICK_XPAD modules
See: raspberrypi/linux#462
popcornmix pushed a commit to Hexxeh/rpi-firmware that referenced this issue Dec 12, 2013
kernel: bump to 3.10.24
2160b5b 
kernel: Make USB_NET_AX88179_178A and JOYSTICK_XPAD modules
See: raspberrypi/linux#462
@popcornmix
Copy link
Collaborator

Updated. rpi-update to test.

@kukabu
Copy link
Author

kukabu commented Dec 13, 2013

Thanks

@kukabu kukabu closed this as completed Dec 13, 2013
@wrobelda wrobelda mentioned this issue Aug 20, 2013
Closed
popcornmix pushed a commit that referenced this issue Sep 30, 2021
@justin-he @rafaeljw
Revert "ACPI: Add memory semantics to acpi_os_map_memory()"
12064c1 
This reverts commit 437b38c.

The memory semantics added in commit 437b38c causes SystemMemory
Operation region, whose address range is not described in the EFI memory
map to be mapped as NormalNC memory on arm64 platforms (through
acpi_os_map_memory() in acpi_ex_system_memory_space_handler()).

This triggers the following abort on an ARM64 Ampere eMAG machine,
because presumably the physical address range area backing the Opregion
does not support NormalNC memory attributes driven on the bus.

 Internal error: synchronous external abort: 96000410 [#1] SMP
 Modules linked in:
 CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.14.0+ #462
 Hardware name: MiTAC RAPTOR EV-883832-X3-0001/RAPTOR, BIOS 0.14 02/22/2019
 pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[...snip...]
 Call trace:
  acpi_ex_system_memory_space_handler+0x26c/0x2c8
  acpi_ev_address_space_dispatch+0x228/0x2c4
  acpi_ex_access_region+0x114/0x268
  acpi_ex_field_datum_io+0x128/0x1b8
  acpi_ex_extract_from_field+0x14c/0x2ac
  acpi_ex_read_data_from_field+0x190/0x1b8
  acpi_ex_resolve_node_to_value+0x1ec/0x288
  acpi_ex_resolve_to_value+0x250/0x274
  acpi_ds_evaluate_name_path+0xac/0x124
  acpi_ds_exec_end_op+0x90/0x410
  acpi_ps_parse_loop+0x4ac/0x5d8
  acpi_ps_parse_aml+0xe0/0x2c8
  acpi_ps_execute_method+0x19c/0x1ac
  acpi_ns_evaluate+0x1f8/0x26c
  acpi_ns_init_one_device+0x104/0x140
  acpi_ns_walk_namespace+0x158/0x1d0
  acpi_ns_initialize_devices+0x194/0x218
  acpi_initialize_objects+0x48/0x50
  acpi_init+0xe0/0x498

If the Opregion address range is not present in the EFI memory map there
is no way for us to determine the memory attributes to use to map it -
defaulting to NormalNC does not work (and it is not correct on a memory
region that may have read side-effects) and therefore commit
437b38c should be reverted, which means reverting back to the
original behavior whereby address ranges that are mapped using
acpi_os_map_memory() default to the safe devicenGnRnE attributes on
ARM64 if the mapped address range is not defined in the EFI memory map.

Fixes: 437b38c ("ACPI: Add memory semantics to acpi_os_map_memory()")
Signed-off-by: Jia He <[email protected]>
Acked-by: Lorenzo Pieralisi <[email protected]>
Acked-by: Catalin Marinas <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@popcornmix @licaon-kter @kukabu