Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcie-brcmstb-bounce64.c: use of dev_err() for informative messages #3266

Closed
maxnet opened this issue Oct 3, 2019 · 2 comments · Fixed by #3268
Closed

pcie-brcmstb-bounce64.c: use of dev_err() for informative messages #3266

maxnet opened this issue Oct 3, 2019 · 2 comments · Fixed by #3268

Comments

@maxnet
Copy link
Contributor

maxnet commented Oct 3, 2019

https://github.com/raspberrypi/linux/blob/rpi-4.19.y/drivers/pci/controller/pcie-brcmstb-bounce64.c#L527

I am getting an informative "dmabounce: initialised" message on my screen despite having "quiet" as kernel cmdline parameter.
Unless that is an actual error requiring attention, can we have dev_info() instead?
@pelwell
Copy link
Contributor

pelwell commented Oct 4, 2019

PR away!

maxnet added a commit to maxnet/linux-1 that referenced this issue Oct 5, 2019
@maxnet
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
08aac0f 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes raspberrypi#3266
@maxnet maxnet mentioned this issue Oct 5, 2019
Merged
@maxnet
Copy link
Contributor Author

maxnet commented Oct 5, 2019

PR away!

Not sure against which of the many branches you like your PRs.
But I currently only use 4.19, so will only submit one for that.

pelwell pushed a commit that referenced this issue Oct 5, 2019
@maxnet @pelwell
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
f1da5f4 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
pelwell pushed a commit that referenced this issue Oct 9, 2019
@maxnet
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
c9620c5 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
pelwell pushed a commit that referenced this issue Oct 9, 2019
@maxnet
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
0ae4b4b 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Oct 11, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
f9edd56 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Oct 11, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
0f6a952 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Oct 21, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
751aef5 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
pelwell pushed a commit that referenced this issue Oct 29, 2019
@maxnet
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
2fe230b 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
pelwell pushed a commit that referenced this issue Oct 30, 2019
@maxnet
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
7bc7ee0 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 1, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
ff80e3f 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 11, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
b37c1f4 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 11, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
61d0a34 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 18, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
0a750fb 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 18, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
df914d9 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 18, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
005ffc6 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 22, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
4c9e473 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 26, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
904d907 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 26, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
ace7893 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 29, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
153d0ef 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Nov 29, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
634102c 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Dec 9, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
72b34df 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Dec 9, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
2d5b57e 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Dec 13, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
dafb3e1 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Dec 13, 2019
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
482ab89 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Jan 3, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
909d993 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Jan 6, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
a25748f 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Jan 30, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
9f5d464 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Feb 6, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
45fb4ee 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Feb 6, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
1df925c 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Feb 20, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
4504993 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Feb 20, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
21f2959 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Feb 25, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
36b2482 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Feb 25, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
2340a88 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
pelwell pushed a commit that referenced this issue Feb 25, 2020
@yaroslavros @pelwell
Ported pcie-brcmstb bounce buffer implementation to ARM64. (#3144)
2cfb1fa 
Ported pcie-brcmstb bounce buffer implementation to ARM64.
This enables full 4G RAM usage on Raspberry Pi in 64-bit mode.

Signed-off-by: Yaroslav Rosomakho <[email protected]>

pcie-brcmstb: Correct SoC name

The Pi 4 SoC is called BCM2711, not BCM2838.

Fixes: "bcm2835-dma: Add proper 40-bit DMA support"
Fixes: "Ported pcie-brcmstb bounce buffer implementation to ARM64."

Signed-off-by: Phil Elwell <[email protected]>

pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages

"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266

pcie-brcmstb: Remove brcm_to_*, add pcie_to_dma40

The DMA framework performs the necessary address conversions for the
common cases based on the dma-ranges DT property. brcm_to_pci and
brcm_to_cpu were probably designed for non-DT use cases, something
which isn't an issue for 2711. This second level of mapping causes
breakage with a non-identity PCIe<->system address mapping, so remove
it completely.

The non-identity mapping also broke the DMA40 support, so add back a
simple translation from PCIe to sys addresses.

arm64 builds also require a wider coherent_dma_mask, otherwise the
bounce buffer allocation is rejected.

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Mar 6, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
13c6da2 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Mar 10, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
25e5e49 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Mar 23, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
40cd303 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Mar 23, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
8045f88 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Mar 27, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
9444397 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Mar 27, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
5dab484 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Apr 1, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
7f69a41 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Apr 1, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
24e0c77 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Apr 7, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
6a56b9a 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Apr 16, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
468819c 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Apr 16, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
5385b06 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Apr 27, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
4121272 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue May 4, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
8b8a0ad 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue May 11, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
e2e43a4 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue May 20, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
48e8b02 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue May 20, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
0418152 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Jun 3, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
3733a9b 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Jun 10, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
24fc5a9 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Jun 17, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
b8a5a01 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Jun 26, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
f280dd7 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Jul 1, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
22d7d43 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
popcornmix pushed a commit that referenced this issue Jul 13, 2020
@maxnet @popcornmix
pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages
62fc3e3 
"dmabounce: initialised" is not an error, so do not log it as such.
Prevents screen polution on OS with "quiet" as kernel parameter.

Closes #3266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pcie-brcmstb-bounce64.c: dev_err() -> dev_info() for info messages maxnet/linux-1
2 participants
@maxnet @pelwell