Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vc4-kms-v3d-overlay + HDMI -> OOps in rpi_touchscreen_dsi_probe #1948

Closed
schnitzeltony opened this issue Apr 5, 2017 · 3 comments
Closed

vc4-kms-v3d-overlay + HDMI -> OOps in rpi_touchscreen_dsi_probe #1948

schnitzeltony opened this issue Apr 5, 2017 · 3 comments
Labels
Waiting for external input Waiting for a comment from the originator of the issue, or a collaborator.

Comments

@schnitzeltony
Copy link
Contributor

Kernel 4.9.16 build in Yocto/OE environment from this source complains:

kernel-log.txt

I see this issue with all my setups:

  • Pi3 + audioinjector-stereo
  • Pi2 + hifiberry-plus

Similar mentioned in #1869
@pelwell
Copy link
Contributor

pelwell commented Apr 6, 2017

@anholt I think there is a bug in rpi_touchscreen_dsi_probe - of_find_i2c_device_by_node (and hence rpi_touchscreen_get_i2c) can return NULL, which isn't caught by IS_ERR(tc->bridge_i2c), and leads to a NULL pointer dereference in i2c_smbus_read_byte_data via rpi_touchscreen_i2c_read.

schnitzeltony added a commit to schnitzeltony/linux-raspberrypi that referenced this issue Apr 7, 2017
@schnitzeltony
Avoid Oops in rpi_touchscreen_dsi_probe by checking for bridge_i2c==NULL
98b2c4e 
Fixes raspberrypi#1948

Signed-off-by: Andreas Müller <[email protected]>
schnitzeltony added a commit to schnitzeltony/linux-raspberrypi that referenced this issue Apr 7, 2017
@schnitzeltony
Avoid Oops in rpi_touchscreen_dsi_probe by checking for bridge_i2c = …
289dfb7 
…NULL

Fixes raspberrypi#1948

Signed-off-by: Andreas Müller <[email protected]>
@schnitzeltony schnitzeltony mentioned this issue Apr 7, 2017
Closed
@JamesH65
Copy link
Contributor

@schnitzeltony Has the linked fix fixed this issue? Please report any further issues or close please.

@JamesH65 JamesH65 added the Waiting for external input Waiting for a comment from the originator of the issue, or a collaborator. label May 19, 2017
@schnitzeltony
Copy link
Contributor Author

schnitzeltony commented May 19, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Waiting for external input Waiting for a comment from the originator of the issue, or a collaborator.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@schnitzeltony @JamesH65 @pelwell