Skip to content

Commit

Permalink
drm/atomic-helper: Do not call ->mode_fixup for CRTC which will be di…
Browse files Browse the repository at this point in the history
…sabled

When a CRTC is going to be disabled, it's state may contain a display mode
with zeroed content.  This could be reproduced by HDMI cable hotplug out
operation with legacy fbdev support in dual display cases.  It would confuse
driver's CRTC callback ->mode_fixup and make the total state be rejected.
So, let's don't call the callback for the CRTC.

Signed-off-by: Liu Ying <[email protected]>
Signed-off-by: Daniel Vetter <[email protected]>
Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
  • Loading branch information
gnuiyl authored and danvet committed May 30, 2016
1 parent c67f695 commit f55f170
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/gpu/drm/drm_atomic_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,9 @@ mode_fixup(struct drm_atomic_state *state)
for_each_crtc_in_state(state, crtc, crtc_state, i) {
const struct drm_crtc_helper_funcs *funcs;

if (!crtc_state->enable)
continue;

if (!crtc_state->mode_changed &&
!crtc_state->connectors_changed)
continue;
Expand Down

0 comments on commit f55f170

Please sign in to comment.