Skip to content

Commit

Permalink
PCI/P2PDMA: Fix a sleeping issue in a RCU read section
Browse files Browse the repository at this point in the history
[ Upstream commit 1e5c66a ]

It is not allowed to sleep within a RCU read section, so use GFP_ATOMIC
instead of GFP_KERNEL here.

Link: https://lore.kernel.org/r/02d9ec4a10235def0e764ff1f5be881ba12e16e8.1704397858.git.christophe.jaillet@wanadoo.fr
Fixes: ae21f83 ("PCI/P2PDMA: Finish RCU conversion of pdev->p2pdma")
Signed-off-by: Christophe JAILLET <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
Reviewed-by: Logan Gunthorpe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
  • Loading branch information
tititiou36 authored and Sasha Levin committed Mar 26, 2024
1 parent 773264c commit 558d8fe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/pci/p2pdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ calc_map_type_and_dist(struct pci_dev *provider, struct pci_dev *client,
p2pdma = rcu_dereference(provider->p2pdma);
if (p2pdma)
xa_store(&p2pdma->map_types, map_types_idx(client),
xa_mk_value(map_type), GFP_KERNEL);
xa_mk_value(map_type), GFP_ATOMIC);
rcu_read_unlock();
return map_type;
}
Expand Down

0 comments on commit 558d8fe

Please sign in to comment.