This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
fix(csi-external-resizer): make patch for v1.1.0+ compatibility #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced.
See kubernetes-csi/external-resizer#122
Signed-off-by: Andrew Zammit [email protected]
Description
csi-external-resizer
failing run #40 because patching withbuild.make.patch
is rejecting:This is due to change in upstream
build.make
as of v1.1.0 introduced by kubernetes-csi/external-resizer#122Partial issue #205.
Checklist
Notes
Untested, so I'm not sure if this is the only thing required for v1.1.0+ compat. The diff was generated from a manual file change, i.e. the original patch was not modified by hand.