Added features toggle

AmpFin.xcodeproj/project.pbxproj

@@ -1547,7 +1547,6 @@
 				MTL_FAST_MATH = YES;
 				ONLY_ACTIVE_ARCH = YES;
 				OTHER_SWIFT_FLAGS = "";
-				SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
 				SWIFT_EMIT_LOC_STRINGS = YES;
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
 				SWIFT_VERSION = 5.0;
@@ -1612,7 +1611,6 @@
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
 				MTL_ENABLE_DEBUG_INFO = NO;
 				MTL_FAST_MATH = YES;
-				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "";
 				SWIFT_COMPILATION_MODE = wholemodule;
 				SWIFT_EMIT_LOC_STRINGS = YES;
 				SWIFT_VERSION = 5.0;

AmpFin.xcodeproj/xcuserdata/rasmus.xcuserdatad/xcschemes/xcschememanagement.plist

@@ -12,22 +12,22 @@
 		<key>Siri Extension.xcscheme_^#shared#^_</key>
 		<dict>
 			<key>orderHint</key>
-			<integer>2</integer>
+			<integer>3</integer>
 		</dict>
 		<key>Widget Extension.xcscheme_^#shared#^_</key>
 		<dict>
 			<key>orderHint</key>
-			<integer>3</integer>
+			<integer>4</integer>
 		</dict>
 		<key>iOS.xcscheme_^#shared#^_</key>
 		<dict>
 			<key>orderHint</key>
-			<integer>0</integer>
+			<integer>1</integer>
 		</dict>
 		<key>tvOS.xcscheme_^#shared#^_</key>
 		<dict>
 			<key>orderHint</key>
-			<integer>1</integer>
+			<integer>2</integer>
 		</dict>
 	</dict>
 	<key>SuppressBuildableAutocreation</key>

AmpFinKit/Package.swift

@@ -18,10 +18,9 @@ let package = Package(
         .package(url: "https://github.com/daltoniam/Starscream.git", from: "4.0.0")
     ],
     targets: [
-        // Remove the underscore to disable app groups for sideloading
-        .target(name: "AFBase", dependencies: [.byName(name: "Starscream")], swiftSettings: [.define("_DISABLE_APP_GROUP")]),
+        .target(name: "AFBase", dependencies: [.byName(name: "Starscream")]),
         .target(name: "AFExtension", dependencies: [.byName(name: "AFBase"), .byName(name: "AFOffline", condition: .when(platforms: [.iOS]))]),
-        .target(name: "AFOffline", dependencies: [.byName(name: "AFBase")], swiftSettings: [.define("_DISABLE_APP_GROUP")]),
+        .target(name: "AFOffline", dependencies: [.byName(name: "AFBase")]),
         .target(
             name: "AFPlayback",
             dependencies: [

AmpFinKit/Sources/AFBase/AmpFinKit.swift

@@ -0,0 +1,11 @@
+//
+//  File.swift
+//  
+//
+//  Created by Rasmus Krämer on 23.01.24.
+//
+
+import Foundation
+
+// this sucks ass, why for the love of god
+public var AFKIT_ENABLE_ALL_FEATURES = true

AmpFinKit/Sources/AFBase/HTTP/JellyfinClient.swift

@@ -28,14 +28,13 @@ public class JellyfinClient {
     #endif
 
     let logger = Logger(subsystem: "io.rfk.ampfin", category: "HTTP")
-    #if DISABLE_APP_GROUP
-    #warning("UserDefaults will not be stored in group container")
-    static let defaults = UserDefaults.standard
-    #else
-    static let defaults = UserDefaults(suiteName: "group.io.rfk.ampfin")!
-    #endif
+    static let defaults = AFKIT_ENABLE_ALL_FEATURES ? UserDefaults(suiteName: "group.io.rfk.ampfin")! : UserDefaults.standard
 
     init(serverUrl: URL!, token: String?, userId: String?) {
+        if !AFKIT_ENABLE_ALL_FEATURES {
+            logger.warning("User data will not be stored in an app group")
+        }
+
         self.serverUrl = serverUrl
         self.token = token
         self.userId = userId

AmpFinKit/Sources/AFOffline/PersistenceManager.swift

@@ -20,12 +20,7 @@ public struct PersistenceManager {
             OfflinePlay.self,
             OfflineFavorite.self,
         ])
-        #if DISABLE_APP_GROUP
-        #warning("SwiftData database will not be stored in group container")
-        let modelConfiguration = ModelConfiguration("AmpFin", schema: schema, isStoredInMemoryOnly: false, allowsSave: true, groupContainer: .identifier("group.io.rfk.ampfin"))
-        #else
-        let modelConfiguration = ModelConfiguration("AmpFin", schema: schema, isStoredInMemoryOnly: false, allowsSave: true)
-        #endif
+        let modelConfiguration = ModelConfiguration("AmpFin", schema: schema, isStoredInMemoryOnly: false, allowsSave: true, groupContainer: AFKIT_ENABLE_ALL_FEATURES ? .identifier("group.io.rfk.ampfin") : .none)
 
         do {
             return try ModelContainer(for: schema, configurations: [modelConfiguration])

Config/Base.xcconfig

@@ -9,3 +9,4 @@
 // https://help.apple.com/xcode/#/dev745c5c974
 
 MARKETING_VERSION = 1.2.2
+SWIFT_ACTIVE_COMPILATION_CONDITIONS = ENABLE_ALL_FEATURES

Config/Debug.xcconfig.template

@@ -10,5 +10,8 @@
 
 #include "Base.xcconfig"
 
+
+SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG ENABLE_ALL_FEATURES
+
 DEVELOPMENT_TEAM = ABC123456
 BUNDLE_ID_PREFIX = me.change

iOS/Core/ContentView.swift

@@ -25,7 +25,9 @@ struct ContentView: View {
                 .onAppear {
                     SpotlightHelper.donate()
                     INMediaUserContext.donate()
+                    #if ENABLE_ALL_FEATURES
                     INPreferences.requestSiriAuthorization { _ in }
+                    #endif
 
                     OfflineManager.shared.updateOfflineItems()
                     OfflineManager.shared.syncPlaysToJellyfinServer()

iOS/Core/iOSApp.swift

@@ -17,6 +17,10 @@ struct iOSApp: App {
     @UIApplicationDelegateAdaptor(AppDelegate.self) var appDelegate
 
     init() {
+        #if !ENABLE_ALL_FEATURES
+        AFKIT_ENABLE_ALL_FEATURES = false
+        #endif
+
         try? Tips.configure([
             .displayFrequency(.daily)
         ])

iOS/Localizable.xcstrings

@@ -322,7 +322,6 @@
       }
     },
     "developedBy" : {
-      "extractionState" : "stale",
       "localizations" : {
         "de" : {
           "stringUnit" : {

iOS/Presentation/Views/Account/AccountSheet.swift

@@ -145,7 +145,7 @@ struct AccountSheet: View {
                 .foregroundStyle(.secondary)
             }
 
-            #if DEBUG
+            #if !ENABLE_ALL_FEATURES
             // quite ironic that this code is bad
             Section {
                 HStack {

iOS/Presentation/Views/Account/LoginView.swift

@@ -47,7 +47,7 @@ struct LoginView: View {
 
             Spacer()
 
-            #if DEBUG
+            #if !ENABLE_ALL_FEATURES
             Text("developedBy")
                 .font(.caption)
                 .foregroundStyle(.secondary)