Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated publish CI/CD workflow #1111

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Updated publish CI/CD workflow #1111

merged 3 commits into from
Nov 10, 2024

Conversation

d-kleine
Copy link
Contributor

@d-kleine d-kleine commented Nov 6, 2024

Description

  • updates the GitHub Actions publish workflow to reference the latest versions of actions used in the steps section under uses to improve performance, security, and compatibility with the latest GitHub Actions features.
  • fixes typo in PR template

Related issues or pull requests

--

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@d-kleine
Copy link
Contributor Author

d-kleine commented Nov 6, 2024

You might also take a look into the run, there is a new trusted publisher for the workflow. For that, you need to log in PyPi 🙂
https://github.com/rasbt/mlxtend/actions/runs/11685967528

@d-kleine d-kleine marked this pull request as ready for review November 6, 2024 12:30
@d-kleine
Copy link
Contributor Author

@rasbt ready for review

@rasbt
Copy link
Owner

rasbt commented Nov 10, 2024

This looks good, thanks for the bump!

You might also take a look into the run, there is a new trusted publisher for the workflow. For that, you need to log in PyPi 🙂
https://github.com/rasbt/mlxtend/actions/runs/11685967528

@rasbt rasbt merged commit 91eb9a7 into rasbt:master Nov 10, 2024
2 checks passed
@d-kleine d-kleine deleted the publish_cicd branch November 11, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants