Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qs audit/rare 3 #6

Merged
merged 1 commit into from
Jul 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: added note that splitAddrs and splitRatios are not validated
  • Loading branch information
charlescrain committed Jul 21, 2023
commit f94f36031eac354d05fa6802b9461e7cc4734295
1 change: 1 addition & 0 deletions src/bazaar/SuperRareBazaarBase.sol
Original file line number Diff line number Diff line change
@@ -136,6 +136,7 @@ abstract contract SuperRareBazaarBase is SuperRareBazaarStorage {
}

/// @notice Sends a payout to all the necessary parties.
/// @dev Note that _splitAddrs and _splitRatios are not checked for validity. Make sure supplied values are correct by using _checkSplits.
/// @dev Sends payments to the network, royalty if applicable, and splits for the rest.
/// @dev Forwards payments to the payment contract if payout is happening in eth.
/// @dev Total amount of ratios should be 100 and is relative to the total ratio left.
1 change: 1 addition & 0 deletions src/utils/MarketUtils.sol
Original file line number Diff line number Diff line change
@@ -125,6 +125,7 @@ library MarketUtils {
}

/// @notice Sends a payout to all the necessary parties.
/// @dev Note that _splitAddrs and _splitRatios are not checked for validity. Make sure supplied values are correct by using _checkSplits.
/// @dev Sends payments to the network, royalty if applicable, and splits for the rest.
/// @dev Forwards payments to the payment contract if payout is happening in eth.
/// @dev Total amount of ratios should be 100 and is relative to the total ratio left.