Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Search Field in bootstrap #2183

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

yparitcher
Copy link
Contributor

Flex is only for tailwind, this was broken when splitting out the styles for the search icon

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Flex is only for tailwind, this wa broken when splitting out the styles for the search icon
@yparitcher
Copy link
Contributor Author

@lrljoe

Please take a look, and let me know if i need to target a different base branch

@lrljoe
Copy link
Collaborator

lrljoe commented Jan 23, 2025

Nope, correct branch, just running tests, then will merge into development branch

Thank you very much for the contribution!

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (e58bfba) to head (bdf338e).
Report is 9 commits behind head on development.

Additional details and impacted files
@@              Coverage Diff               @@
##             development    #2183   +/-   ##
==============================================
  Coverage          90.98%   90.98%           
  Complexity          2011     2011           
==============================================
  Files                218      218           
  Lines               4539     4539           
==============================================
  Hits                4130     4130           
  Misses               409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 5b23dfb into rappasoft:development Jan 24, 2025
10 checks passed
@yparitcher yparitcher deleted the css branch January 24, 2025 01:32
@lrljoe lrljoe mentioned this pull request Feb 27, 2025
9 tasks
lrljoe added a commit that referenced this pull request Feb 28, 2025
## [v3.7.0] - 2025-02-27

### Bug Fixes
- Filters urgent fixes - correct Filter Default QueryString by @lrljoe in #2188
- Fix Search Field in bootstrap by @yparitcher in #2183
- Add "after-tools" configurable area by @lrljoe in #2180

### New Features
- Add setFilterPillTitleAsHtml by @lrljoe in #2204
- Enable setting styles for sorting pills as a configuration by @HussamAlhennawi in #2179
- Enable setting styles for filter pills as a configuration by @HussamAlhennawi in #2178
- Enable setting styles for column select as a configuration by @HussamAlhennawi in #2175
- BulkActionTweaks - Adding default checkbox, customising attribute behaviours by @lrljoe in #2203
- Laravel v12 Support by @lrljoe in #2217

### Tweaks
- Tweak for text pill title by @lrljoe in #2206
- Tweak Return Types by @lrljoe in #2205
- Migrate Column/Filter Traits by @lrljoe in #2202
- Filter Rationalisation & Livewire Array Filter improvements by @lrljoe in #2191
- Move Filter View Traits by @lrljoe in #2189
- Filter Trait - Reorganization by @lrljoe in #2181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants